Merged
Conversation
Member
pwtyler
commented
Jun 1, 2023
pwtyler
commented
- Fixes PHP 8.2 deprecated dynamic property error [#251]
- Update CONTRIBUTING.md [#252].
- Update informational Error message for the case of headers already sent [#249].
- Add pantheon-wp-coding-standards [#247].
* use pantheon coding standards exclude vip minimum which flags a lot of session-related code * add phpcbf script and run it * remove empty return statement per phpcs * set the linting box to php8.0
…ent (#249) * Enhance informational Error message for the case of headers already sent This code update enhances the error message displayed by the plugin when it is unable to perform its intended functionality due to headers already being sent. The original error message was "_session_set_save_handler(): Session save handler cannot be changed after headers have already been sent_" has been transformed into a more user-friendly and informative message. The updated error message helps users understand that the plugin was unable to work properly and provides insight into the cause, such as PHP throwing errors, the case that happened for me. By improving the error message, users can better troubleshoot and resolve the issue instead of thinking that wp-native-php-sessions plugin falied. * Add textdomain & fix spacing * fix spacing --------- Co-authored-by: Chris Reynolds <chris@jazzsequence.com>
* update contrib.md and version number * use correct pr number * fix lint error introduced in #249
* Adds $admin property This PR intends to fix this error added by PHP 8.2: Deprecated: Creation of dynamic property Pantheon_Sessions::$admin is deprecated in /usr/src/app/content/plugins/wp-native-php-sessions/pantheon-sessions.php on line 93 * fixes lints that were missed in previous PR * bump version * bump version, tested up to & update changelog * re-add plucked stable tag
jazzsequence
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.