[CMSP-353] Add pantheon-wp-coding-standards#247
Merged
jazzsequence merged 4 commits intodevelopfrom May 3, 2023
Merged
Conversation
exclude vip minimum which flags a lot of session-related code
pwtyler
approved these changes
May 2, 2023
pwtyler
pushed a commit
that referenced
this pull request
Jun 1, 2023
* use pantheon coding standards exclude vip minimum which flags a lot of session-related code * add phpcbf script and run it * remove empty return statement per phpcs * set the linting box to php8.0
Merged
pwtyler
pushed a commit
that referenced
this pull request
Jun 1, 2023
* use pantheon coding standards exclude vip minimum which flags a lot of session-related code * add phpcbf script and run it * remove empty return statement per phpcs * set the linting box to php8.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds our coding standards.
Ignores all of the WPVIPMinimum standard. This flagged a lot of stuff around PHP sessions and manipulating
php.iniwhich we would have otherwise had to ignore in the standard. I think those rules probably are okay most of the time, but obviously not in a plugin specifically designed to handle standards, so it makes sense to just ignore those rules here.