Repository navigation
Stop GPG agent before removing signature-verification home - #1273
Merged
Merged
Conversation
Closed
2 of 5 tasks
Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix cleanup failure due to EBUSY error in GPG signature verification
Sep 28, 2026
brunoborges
marked this pull request as ready for review
September 28, 2026 23:47
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation, generated bundles, and tests consistently address the reported NFS cleanup failure.
Review effort: Balanced
Findings: None
What changed in this PR
Stops temporary GPG agents before deleting signature-verification homes, preventing NFS cleanup failures.
Changes:
- Extracts reusable best-effort GPG agent shutdown.
- Applies shutdown to verification cleanup.
- Adds success, failure, and unavailable-
gpgconfcoverage.
| File | Description |
|---|---|
src/gpg.ts |
Stops agents before home removal. |
__tests__/gpg.test.ts |
Covers all cleanup outcomes. |
dist/setup/81.index.js |
Updates generated setup bundle. |
dist/setup/220.index.js |
Updates generated setup bundle. |
dist/setup/463.index.js |
Updates generated setup bundle. |
dist/cleanup/index.js |
Updates generated cleanup bundle. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
brunoborges
approved these changes
Sep 29, 2026
1 task
gregor-dietrich
pushed a commit
to gregor-dietrich/Midas
that referenced
this pull request
Oct 24, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-java](https://github.com/actions/setup-java) | action | minor | `v6.0.1` → `v6.1.0` | --- ### Release Notes <details> <summary>actions/setup-java</summary> ### [`v6.1.0`](https://github.com/actions/setup-java/releases/tag/v6.1.0) [Compare Source](actions/setup-java@v6.0.1...v6.1.0) ##### What's Changed - Preserve compound Liberica build versions from .sdkmanrc by [@​brunoborges](https://github.com/brunoborges) with [@​Copilot](https://github.com/Copilot) in [#​1268](actions/setup-java#1268) - Support Temurin on Linux RISC-V by [@​yawkat](https://github.com/yawkat) in [#​1269](actions/setup-java#1269) - Stop GPG agent before removing signature-verification home by [@​brunoborges](https://github.com/brunoborges) with [@​Copilot](https://github.com/Copilot) in [#​1273](actions/setup-java#1273) - Prefer Zulu 4-segment hotfix builds when resolving version ranges by [@​brunoborges](https://github.com/brunoborges) in [#​1278](actions/setup-java#1278) - Support Temurin JEP 322 patch versions like 26.0.2.1+1 by [@​brunoborges](https://github.com/brunoborges) in [#​1279](actions/setup-java#1279) - chore(deps): bump undici from 6.28.0 to 6.29.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​1274](actions/setup-java#1274) - chore(deps): bump the monthly-npm-updates group with 13 updates by [@​dependabot](https://github.com/dependabot)\[bot] in [#​1276](actions/setup-java#1276) - feat: support Maven server credential origins by [@​YunaBraska](https://github.com/YunaBraska) in [#​1282](actions/setup-java#1282) - Support Maven plugin repositories in generated settings.xml by [@​brunoborges](https://github.com/brunoborges) in [#​1286](actions/setup-java#1286) ##### New Contributors - [@​yawkat](https://github.com/yawkat) made their first contribution in [#​1269](actions/setup-java#1269) - [@​YunaBraska](https://github.com/YunaBraska) made their first contribution in [#​1282](actions/setup-java#1282) **Full Changelog**: <actions/setup-java@v6.0.1...v6.1.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNjUuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjE2NS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.vptr.de/gregor/midas2/pulls/113 Reviewed-by: gregor <1+gregor@noreply.localhost> Co-authored-by: Renovate Bot <renovate@vptr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
On self-hosted runners with NFS-backed
RUNNER_TEMP, signature verification can succeed but the step can fail while removing an agent-held.nfs*file.gpgconfis unavailable.Related issue:
NFS-backed
RUNNER_TEMPsignature-verification cleanup failure.Download URL:
Not applicable; no new distribution.
License:
Not applicable; no new distribution.
Check list: