Skip to content

Support Temurin on Linux RISC-V - #1269

Merged
brunoborges merged 6 commits into
actions:mainfrom
yawkat:fix/temurin-riscv64
Sep 25, 2026
Merged

brunoborges merged 6 commits into
actions:mainfrom
yawkat:fix/temurin-riscv64

Conversation

@yawkat

@yawkat yawkat commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Description:
Add riscv64 as a canonical architecture and allow Temurin distributions to use it on Linux.

setup-java v5 forwarded the runner architecture to Adoptium and successfully installed Temurin on RISC-V. The centralized platform validation added in v6 currently rejects the same configuration before reaching the Temurin catalog, even though Adoptium publishes Linux riscv64 JDK and JRE artifacts.

This change:

  • adds riscv64 to the canonical architecture contract;
  • enables it only for Temurin on Linux;
  • verifies case normalization, platform validation, and Adoptium query pass-through;
  • updates the action metadata and compatibility documentation; and
  • regenerates dist/setup/index.js.

Related issue:
yawkat/lz4-java#87

Check list:

  • Ran npm run check locally (format, lint, build, test) and all checks pass.
  • Documentation changes are included.
  • Tests were added or updated to cover the changes.
yawkat and others added 3 commits September 12, 2026 02:33
Co-Authored-By: multicode <multicode@yawk.at>
Co-Authored-By: multicode <multicode@yawk.at>
Co-Authored-By: multicode <multicode@yawk.at>
Copilot AI lite review requested due to automatic review settings September 12, 2026 02:35
@yawkat
yawkat requested a review from a team as a code owner September 12, 2026 02:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Adds Linux riscv64 support for Temurin by updating architecture validation, documentation, tests, metadata, and the bundled runtime.

Changes:

  • Adds canonical riscv64 support for Temurin on Linux.
  • Updates compatibility documentation and action metadata.
  • Adds coverage for normalization, validation, and Adoptium pass-through.
File summaries
File Description
src/distributions/platform-types.ts Adds canonical and Temurin Linux riscv64 support.
README.md Documents riscv64 as a canonical architecture.
docs/advanced-usage.md Updates the compatibility matrix.
dist/setup/index.js Regenerates the runtime bundle.
action.yml Updates architecture input metadata.
__tests__/java-platform-contract.test.ts Tests normalization and validation.
__tests__/distributors/temurin-installer.test.ts Tests Adoptium architecture pass-through.
Review details
  • Files reviewed: 6/7 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@yawkat

yawkat commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

@luhenry PTAL as well, since you worked on lz4-java RISC-V support

@luhenry luhenry left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/distributions/platform-types.ts Resolved
Co-Authored-By: multicode <multicode@yawk.at>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new normalization test uses already-lowercase input and therefore does not verify case normalization.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@brunoborges
brunoborges merged commit 97c5a5e into actions:main Sep 25, 2026
84 checks passed
@luhenry

luhenry commented Sep 28, 2026

Copy link
Copy Markdown

Thanks @brunoborges !

gregor-dietrich pushed a commit to gregor-dietrich/Midas that referenced this pull request Oct 24, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-java](https://github.com/actions/setup-java) | action | minor | `v6.0.1` → `v6.1.0` |

---

### Release Notes

<details>
<summary>actions/setup-java</summary>

### [`v6.1.0`](https://github.com/actions/setup-java/releases/tag/v6.1.0)

[Compare Source](actions/setup-java@v6.0.1...v6.1.0)

##### What's Changed

- Preserve compound Liberica build versions from .sdkmanrc by [@&#8203;brunoborges](https://github.com/brunoborges) with [@&#8203;Copilot](https://github.com/Copilot) in [#&#8203;1268](actions/setup-java#1268)
- Support Temurin on Linux RISC-V by [@&#8203;yawkat](https://github.com/yawkat) in [#&#8203;1269](actions/setup-java#1269)
- Stop GPG agent before removing signature-verification home by [@&#8203;brunoborges](https://github.com/brunoborges) with [@&#8203;Copilot](https://github.com/Copilot) in [#&#8203;1273](actions/setup-java#1273)
- Prefer Zulu 4-segment hotfix builds when resolving version ranges by [@&#8203;brunoborges](https://github.com/brunoborges) in [#&#8203;1278](actions/setup-java#1278)
- Support Temurin JEP 322 patch versions like 26.0.2.1+1 by [@&#8203;brunoborges](https://github.com/brunoborges) in [#&#8203;1279](actions/setup-java#1279)
- chore(deps): bump undici from 6.28.0 to 6.29.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;1274](actions/setup-java#1274)
- chore(deps): bump the monthly-npm-updates group with 13 updates by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;1276](actions/setup-java#1276)
- feat: support Maven server credential origins by [@&#8203;YunaBraska](https://github.com/YunaBraska) in [#&#8203;1282](actions/setup-java#1282)
- Support Maven plugin repositories in generated settings.xml by [@&#8203;brunoborges](https://github.com/brunoborges) in [#&#8203;1286](actions/setup-java#1286)

##### New Contributors

- [@&#8203;yawkat](https://github.com/yawkat) made their first contribution in [#&#8203;1269](actions/setup-java#1269)
- [@&#8203;YunaBraska](https://github.com/YunaBraska) made their first contribution in [#&#8203;1282](actions/setup-java#1282)

**Full Changelog**: <actions/setup-java@v6.0.1...v6.1.0>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNjUuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjE2NS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.vptr.de/gregor/midas2/pulls/113
Reviewed-by: gregor <1+gregor@noreply.localhost>
Co-authored-by: Renovate Bot <renovate@vptr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants