Repository navigation
ci: require a version bump on every PR - #236
Merged
Merged
Conversation
ccampbell-aai
force-pushed
the
ccampbell/ci-version-bump-check
branch
2 times, most recently
from
September 2, 2026 21:47
7a3a73f to
49fa9a6
Compare
ccampbell-aai
added
skip-version-bump
2 tasks done
aurpsis-aai
approved these changes
Sep 2, 2026
Adds a Version Bump Check workflow that fails a PR into master unless assemblyai/__version__.py is strictly greater than the base branch's version. Versions are compared with packaging.version so the older zero-padded scheme still orders correctly. A skip-version-bump label bypasses the check for PRs that intentionally ship no release. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ccampbell-aai
force-pushed
the
ccampbell/ci-version-bump-check
branch
from
September 2, 2026 22:49
49fa9a6 to
b79a249
Compare
ccampbell-aai
marked this pull request as ready for review
September 2, 2026 22:52
ccampbell-aai
added a commit
to Kayvan-Zahiri/assemblyai-python-sdk
that referenced
this pull request
Sep 2, 2026
Resolves the __version__.py conflict: master moved 1.2.0 -> 1.2.3 (AssemblyAI#235, AssemblyAI#237, AssemblyAI#236) after this branch bumped to 1.2.1, so the patch bump becomes 1.2.4. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ccampbell-aai
added a commit
to gsharp-aai/assemblyai-python-sdk
that referenced
this pull request
Sep 2, 2026
Resolves the __version__.py conflict: master moved 1.2.0 -> 1.2.5 (AssemblyAI#235, AssemblyAI#237, AssemblyAI#236, AssemblyAI#234, AssemblyAI#238) after this branch bumped to 1.3.0. 1.3.0 is still the next minor, so the branch's bump stands. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterand fails unlessassemblyai/__version__.pyis strictly greater than the base branch's version.packaging.version.Version, so the older zero-padded scheme (0.68.00→1.0.0) still orders correctly and downgrades are rejected.skip-version-bumplabel (created in this repo) to a PR that intentionally ships no release (CI-only, docs-only). The trigger includeslabeled/unlabeled, so applying or removing the label re-runs the check without a new push.1.2.2→1.2.3so this PR passes its own check.Why
Publishing is tag-driven off
master, so a merge without a bump means the next tag either re-uses a version or has to be bumped in a follow-up. No workflow enforced this before; #230 merged without a bump.Follow-up after merge
Add
Version incrementedas a required status check onmasterin branch protection. Until then the job is advisory only.Test plan
1.2.1on master underneath it (base1.2.1== head1.2.1) — exactly the case it exists forskip-version-bump→ job skipped; removing it → job re-ran and passed🤖 Generated with Claude Code