Repository navigation
fix(types): guard model_config so the pydantic v1 fallback keeps its config - #234
Merged
ccampbell-aai merged 3 commits intoSep 2, 2026
Merged
Conversation
…config
On Python < 3.14 a plain `pip install assemblyai` gets no pydantic-settings,
so types.py falls back to the `pydantic.v1` shim with pydantic_v2 = False.
There a bare `model_config = ConfigDict(...)` is not config, pydantic v1
reads it as an untyped attribute and turns it into a real model field.
ListTranscriptParameters lost use_enum_values, so list_transcripts sent
`status=TranscriptStatus.completed` plus a stray `model_config` query param.
RawTranscriptionConfig lost extra="allow", so the escape hatch for
not-yet-modeled server fields dropped them.
Apply the same `if pydantic_v2:` guard Settings already uses. Adds two
regression tests and removes the discard("model_config") workaround in
test_domains.py that was papering over the phantom field.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DQughgr95y4B9H1jfaQH8o
Contributor
|
Hey @Kayvan-Zahiri, great find and thank you for the PR! Please include a patch version bump and I'll approve. |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQughgr95y4B9H1jfaQH8o
Contributor
Author
|
Bumped to 1.2.1. Patch rather than minor since this is a fix, matching how the recent PRs bump |
Resolves the __version__.py conflict: master moved 1.2.0 -> 1.2.3 (AssemblyAI#235, AssemblyAI#237, AssemblyAI#236) after this branch bumped to 1.2.1, so the patch bump becomes 1.2.4. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Thanks for the fix and for bumping the version. Master moved on underneath this branch (#235, #237 and #236 took it from 1.2.0 to 1.2.3), so I merged master in and resolved the |
ccampbell-aai
approved these changes
Sep 2, 2026
ccampbell-aai
added a commit
to gsharp-aai/assemblyai-python-sdk
that referenced
this pull request
Sep 2, 2026
Resolves the __version__.py conflict: master moved 1.2.0 -> 1.2.5 (AssemblyAI#235, AssemblyAI#237, AssemblyAI#236, AssemblyAI#234, AssemblyAI#238) after this branch bumped to 1.3.0. 1.3.0 is still the next minor, so the branch's bump stands. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.pyrequirespydantic-settingsonly on Python >= 3.14, so a plainpip install assemblyaion 3.9 to 3.13 has no pydantic-settings. Thefrom pydantic_settings import ...intypes.pythen raises ImportError and the SDK runs thepydantic.v1fallback withpydantic_v2 = False. On that path a baremodel_config = ConfigDict(...)is not config at all: pydantic v1 sees an untyped class attribute and makes it a real model field.Settingsalready has theif pydantic_v2:guard; two classes were missed.ListTranscriptParameters:use_enum_valuesis inert, solist_transcriptssendsinstead of
limit=2&status=completed.RawTranscriptionConfig:extra="allow"is inert, so unmodeled fields are dropped.RawTranscriptionConfig(punctuate=True, x="y").dict()gave{'punctuate': True, 'model_config': {'extra': 'allow'}}.Two regression tests, both failing before and passing after.
tests/unit: 472 pass on master, 474 here, on pydantic 1.10.26 and 2.13.5. ruff 0.3.5 and mypy 1.5.1 report nothing new. Also removed thediscard("model_config")line intest_domains.pythat was hiding the phantom field.🤖 Generated with Claude Code