Problem/Motivation

phpstan reports,

web/modules/composer/queue_stats/src/Plugin/Block/ListBlock.php 179 Undefined variable: $hide_stat

and indeed, although $hide_stat is defined a few lines before in the parent function, it is used inside a nested function (closure) where it is not defined.

Proposed resolution

Pass $hide_stat into the inner function so it is defined in that scope.

Remaining tasks

Make an MR.

Issue fork queue_stats-3619362

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !7

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review
benstallings’s picture

benstallings commented
Issue summary: View changes

achton made their first commit to this issue’s fork.

achton’s picture

achton
Location Denmark
commented

Thanks, merged for 2.0.0-rc1.

achton’s picture

achton
Location Denmark
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • achton committed dbaae217 on 2.x authored by benstallings 
    fix: #3619362 Pass $hide_stat into the nested function in ListBlock

By...