Remove the sdc module from core

This can be done now right?

I guess one question is we usually move to contrib but we're not doing that here.

Is there anything special we have to do?

AFAIK we never had a hook_update uninstalling it, so we should land that in 11.x if we want this to happen in 12.x

Update hook in this ticket or follow up? Imagine it would be small enough probably good all do here?

Well it will take special consideration.

@smustgrave You can't do both sdc.info.yml removal and the hook in the same MR (or even release)

Could do an MR to remove it like we got and an MR to 11.x to uninstall. Just meant the same ticket

I made an MR for 11.x. I copied the post-update function that was put in to uninstall migrate_drupal. As far as I could tell that other function didn't have tests, but I didn't check thoroughly because that MR affected 853 files.

The problem is that someone can update from 11.4.0 which won't have this.

I think we can remove it in one go though with an update hook, we just need to drop the schema from key value and update the config right?

Think this is small enough to still make 12 maybe.

We already should have uninstalled the module via system_post_update_sdc_uninstall(), so I don't think we need anything in 11.x here and we can just delete it in 12.

I can commit this

Doing this today.