Polyfills: improve handling of custom error message#97
Merged
Conversation
The assertions in the `AssertClosedResource` trait generate a specific error message. However, if a custom `$message` parameter was passed, that message would not be displayed and only the custom `$message` would be shown when the assertion failed. As the PHPUnit native error message from the _underlying_ assertion used - _"true is not false"_ - would be obscuring the real issue, this commit adjusts the code to always display the assertion specific error message as well. Includes tests safeguarding the fix.
Some of the assertions in the `AssertFileDirectory` trait generate a specific error message. However, if a custom `$message` parameter was passed, that message would not be displayed and only the custom `$message` would be shown when the assertion failed. As the PHPUnit native error message from the _underlying_ assertion used - _"true is not false"_ - would be obscuring the real issue, this commit adjusts the code to always display the assertion specific error message as well. Includes tests safeguarding the fix.
Some of the assertions in the `AssertStringContains` trait generate a specific error message. However, if a custom `$message` parameter was passed, that message would not be displayed and only the custom `$message` would be shown when the assertion failed. As the PHPUnit native error message from the _underlying_ assertion used - _"true is not false"_ - would be obscuring the real issue, this commit adjusts the code to always display the assertion specific error message as well. Includes tests safeguarding the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssertClosedResource: improve handling of custom error message
The assertions in the
AssertClosedResourcetrait generate a specific error message.However, if a custom
$messageparameter was passed, that message would not be displayed and only the custom$messagewould be shown when the assertion failed.As the PHPUnit native error message from the underlying assertion used - "true is not false" - would be obscuring the real issue, this commit adjusts the code to always display the assertion specific error message as well.
Includes tests safeguarding the fix.
AssertFileDirectory: improve handling of custom error message
Some of the assertions in the
AssertFileDirectorytrait generate a specific error message.However, if a custom
$messageparameter was passed, that message would not be displayed and only the custom$messagewould be shown when the assertion failed.As the PHPUnit native error message from the underlying assertion used - "true is not false" - would be obscuring the real issue, this commit adjusts the code to always display the assertion specific error message as well.
Includes tests safeguarding the fix.
AssertStringContains: improve handling of custom error message
Some of the assertions in the
AssertStringContainstrait generate a specific error message.However, if a custom
$messageparameter was passed, that message would not be displayed and only the custom$messagewould be shown when the assertion failed.As the PHPUnit native error message from the underlying assertion used - "true is not false" - would be obscuring the real issue, this commit adjusts the code to always display the assertion specific error message as well.
Includes tests safeguarding the fix.