Add --recreate-db option to install-wp-tests.sh#320
Closed
vcanales wants to merge 4 commits intowp-cli:mainfrom
Closed
Add --recreate-db option to install-wp-tests.sh#320vcanales wants to merge 4 commits intowp-cli:mainfrom
--recreate-db option to install-wp-tests.sh#320vcanales wants to merge 4 commits intowp-cli:mainfrom
Conversation
This adds an option to remove the need for user input when running the script for confirming database recreation, helpful when it is run in a CI context, such as a part of a GitHub Action. Also refactors the help message, and when it is printed.
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks for the pull request, @vcanales !
Can you add a corresponding scenario to features/install-wp-tests.feature?
|
I see that the test is added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
--recreate-dboption to remove the need for user input when running thescript for confirming database recreation, helpful when it is run in a CI context, such as a part of a GitHub Action. The command can be safely run without flags, and it will respect the order of the other options.
Also, refactors the help message and when it is printed.