Repository navigation
Conversation
This change prevents elements from being unfocused due to the `disabled` attribute being set. Losing focus on an element that gains `disabled` is a common UX issue. In order to facilitate this change, controls with pickers (Date, Select, File) must close their open pickers. Controls also need to be updated to check their `actually disabled` status in order to close pickers and form controls must ignore key events while the disabled control is focused. Disabled controls cannot be focused into. Fixes whatwg#13159
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents elements from being unfocused due to the
disabledattribute being set. Losing focus on an element that gainsdisabledis a common UX issue.In order to facilitate this change, controls with pickers (Date, Select, File) must close their open pickers. Controls also need to be updated to check their disabled status in order to close pickers and ignore key events while the disabled control is focused. Disabled controls cannot be focused into.
Fixes #13159
(See WHATWG Working Mode: Changes for more details.)
/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/webappapis.html ( diff )