Addition: allow aria-hidden on picture element#352
Merged
scottaohara merged 8 commits intogh-pagesfrom Oct 26, 2021
Merged
Conversation
Revise the allowances for the `picture` element to allow for the `aria-hidden` attribute.
scottaohara
added
the
needs implementation commitment
ryanve
reviewed
Sep 20, 2021
ryanve
reviewed
Sep 20, 2021
This comment has been minimized.
This comment has been minimized.
scottaohara
added
the
Meets 2 implementations req
scottaohara
removed
the
needs implementation commitment
Member
|
Note, you need to do the same for the other pull requests. I'll review those and make sure it's all good. Feel free to also ping me for review on those. However, we don't need to wait to merge things into the Editor's draft. The minute the spec gets published as REC, we can then start pushing all the ".addition" to /TR/. In the meantime, I've disabled the auto-publish.yml script. |
Member
|
Actually, it's a little more nuanced: https://github.com/w3c/tr-design/blob/e40643f08e80f65a31d54ab2fb9e3ca34fa6cfcc/src/base.css#L35-L38 The things in the process are outlined in: |
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
scottaohara
added a commit
that referenced
this pull request
May 19, 2022
pkra
pushed a commit
to w3c/aria
that referenced
this pull request
May 20, 2024
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label' related to w3c/html-aria#419 - w3c/html-aria#352 - w3c/html-aria#367 (and follow on [commit](w3c/html-aria@9cc2c0a)) - w3c/html-aria#360 - w3c/html-aria#353 - w3c/html-aria#372 - w3c/html-aria#402 - w3c/html-aria#404 - w3c/html-aria#403 - w3c/html-aria#396 - w3c/html-aria#391 - w3c/html-aria#369 - w3c/html-aria#381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revise the allowances for the
pictureelement to allow for thearia-hiddenattribute.Need at least two checkers to accept this change before we can merge.
Closes #346
Preview | Diff