[6.x] Use he-tree i18n prop for tree aria instructions - #14499
Merged
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
@he-tree/vueto 2.10.5, which supports ani18n.instructionsprop for the screen-reader instructions string instead of assigningariaInstructionson the component instance after mount.Replaces the workaround added in #14465 in
PageTree.vueandpreferences/nav/Edit.vuewith:i18n="treeDraggableI18n"(computed from__('messages.tree_aria_instructions')).Removes the
.he-tree-sr-onlyTailwind bridge inpage-tree.css; newer he-tree renders that node with thesr-onlyclass directly.Made with Cursor