Skip to content

DOC: link to a local file name with spaces - #699

Draft
mgeier wants to merge 1 commit into
spatialaudio:masterfrom
mgeier:local-file-with-spaces
Draft

DOC: link to a local file name with spaces#699
mgeier wants to merge 1 commit into
spatialaudio:masterfrom
mgeier:local-file-with-spaces

Conversation

@mgeier

@mgeier mgeier commented Jan 8, 2023

Copy link
Copy Markdown
Member

No description provided.

@smith-kyle

smith-kyle commented Feb 2, 2024

Copy link
Copy Markdown

I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/spatialaudio/nbsphinx/pull/699

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.
@mgeier

mgeier commented Feb 2, 2024

Copy link
Copy Markdown
Member Author

Thanks for the hint @smith-kyle!

Ironically, the link that this PR is all about doesn't seem to work on the service.
None of the internal links seem to work, nor does math, tables, <div> elements or links within them.
@smith-kyle

smith-kyle commented Feb 2, 2024

Copy link
Copy Markdown

I appreciate the feedback @mgeier! Latex equations, and github flavored tables will be supported soon
@mgeier
mgeier force-pushed the local-file-with-spaces branch 2 times, most recently from 8796068 to 82dd25f Compare February 3, 2024 10:09
@mgeier mgeier mentioned this pull request Feb 3, 2024
Draft
@mgeier
mgeier marked this pull request as draft February 3, 2024 11:13
@mgeier
mgeier force-pushed the local-file-with-spaces branch from 82dd25f to b729b2d Compare May 2, 2024 20:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mgeier @smith-kyle