Performance degradation with context pool after v0.3.0 #154

Activity

1. srabraham commented on Oct 21, 2025

   

   srabraham

   on Oct 21, 2025

   Last edited by srabraham

   More actions

   @adriantam I will happily try to debug this. Could you please provide a sample piece of code that exhibits this behavior? This would be great in the form of a Benchmark test. https://pkg.go.dev/testing#hdr-Benchmarks
2. srabraham commented on Dec 12, 2025

   

   srabraham

   on Dec 12, 2025

   More actions

   @adriantam this issue doesn't provide enough detail to be a useful bug report. Here's a benchmark test I made that satisfies the vague requirements in your original comment. The benchmark results on my machine are basically identical at HEAD versus at 1df97ec from Jan 2023. That's the farthest back we can go, because commits from before that won't build, due to a missing repository.

   // to be appended to pool/context_pool_test.go
   func BenchmarkContextPool(b *testing.B) {
   	for b.Loop() {
   		p := pool.New().WithContext(b.Context())
   		for i := 0; i < 1000; i++ {
   			p.Go(func(ctx context.Context) error {
   				for j := 0; j < 10000; j++ {
   					hasher := sha256.New()
   					hasher.Write([]byte(strconv.Itoa(i)))
   					_ = hasher.Sum(nil)
   				}
   				return nil
   			})
   		}
   		err := p.Wait()
   		if err != nil {
   			b.Fatal(err)
   		}
   	}
   }

   👀React with 👀1Reacted by Anurag Bandyopadhyay