You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
In ErrorPool, store errors as []error instead of flattened error #143
But this makes it incredibly difficult, without a recursive function, to pull the underlying errors out when consuming them from ErrorPool#Wait() (the current approach also stores the errors in a more suboptimal manner leading to more memory usage, but this isn't a huge deal):
I don't mind doing the work for this, and it should be noted that it is backwards compatible w/ folks in the wild who have created their own functions like unwrapErrors above.
@camdencheek sorry to bother, but I saw you active in a prior issue. Any thoughts on whether I can move ahead with contributing this code? Would love to get this ironed out if possible, and thanks for creating such a great library!
Activity
[-]In errorPool, stored errors as `[]error` instead of `error`[/-][-]In `ErrorPool`, stored errors as `[]error` instead of `error`[/-]akallu commentedon Dec 19, 2024
@camdencheek sorry to bother, but I saw you active in a prior issue. Any thoughts on whether I can move ahead with contributing this code? Would love to get this ironed out if possible, and thanks for creating such a great library!
camdencheek commentedon Dec 19, 2024
Hey @akallu, sorry for the delayed reponse. This is a great suggestion -- I'd be happy to accept a contribution here 🙂