Support passing arguments to worker constructor #76

Activity

1. jezdez commented on Nov 29, 2018

   

   jezdez

   on Nov 29, 2018

   Last edited by jezdez

   Contributor

   More actions

   Assuming you mean the RQ.get_worker method: yes. But we shouldn't simply pass all **kwargs to Worker but define some options that are shared in the RQ instance instead. In other words let's try to keep Flask-RQ2 a high-level API that hides some of the low-level features.

   Here are the arguments that need to be added:

   • name (add as RQ.worker_name?)
   • default_result_ttl (reuse RQ.default_result_ttl)
   • default_worker_ttl (add as RQ.default_worker_ttl)
   • job_monitoring_interval (add as RQ.job_monitoring_interval, and add as option to worker CLI callback)
2. shouichi commented on Nov 30, 2018

   

   shouichi

   on Nov 30, 2018

   Author

   More actions

   But we shouldn't simply pass all **kwargs to Worker but define some options that are shared in the RQ instance instead. In other words let's try to keep Flask-RQ2 a high-level API that hides some of the low-level features.

   Got it (I understand the RQ's goal is keeping it simple).

   • name (add as RQ.worker_name?)

   Make the default value None and allow users to pass arbitrary string. That why the RQ keeps the current behavior. Correct?

   • job_monitoring_interval (add as RQ.job_monitoring_interval, and add as option to worker CLI callback)

   Do you mean adding an option (@click.option) to this func?

   Flask-RQ2/src/flask_rq2/cli.py

   Line 136 in 94f8d2f

   def worker(rq, ctx, burst, logging_level, name, path, results_ttl,

   Thanks!
3. alvin1 commented on Dec 6, 2018

   

   alvin1

   on Dec 6, 2018

   More actions

   From my use of Flask-RQ2, I'd like to add:
   date_format
   log_format

   These 2 args are useful for the logging