Add a testing option to use fakeredis #55

Activity

1. jezdez commented on Mar 26, 2018

   

   jezdez

   on Mar 26, 2018

   Contributor

   More actions

   There is a class attribute called connection_class that is used in the RQ._connect method to create the Redis client. Since fakeredis supports the from_url API it should be enough to subclass the RQ class and overwrite connection_class with the dotted path to the fakeredis client class.
2. moritz89 commented on Mar 26, 2018

   

   moritz89

   on Mar 26, 2018 via email

   ContributorAuthor

   More actions

   Would it make sense to add example code somewhere? Or is there a blog or repo that can be used as an example?

   …

   On 26. Mar 2018, at 09:11, Jannis Leidel ***@***.***> wrote: There is a class attribute called connection_class that is used in the RQ._connect method to create the Redis client. Since fakeredis supports the from_url API it should be enough to subclass the RQ class and overwrite connection_class with the dotted path to the fakeredis client class. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
3. jezdez commented on Mar 26, 2018

   

   jezdez

   on Mar 26, 2018

   Contributor

   More actions

   Would make sense to add a testing section to the docs. Mind opening a PR?
4. moritz89 commented on Mar 27, 2018

   

   moritz89

   on Mar 27, 2018

   ContributorAuthor

   More actions

   Check that 👍🏼
5. moritz89 commented on Mar 29, 2018

   

   moritz89

   on Mar 29, 2018

   ContributorAuthor

   More actions

   It was actually much simpler than that, just set RQ_CONNECTION_CLASS = 'fakeredis.FakeStrictRedis' when setting the config variables. The relevant sections are:

   class Config:
       APP_NAME = os.environ.get('APP_NAME')
       RQ_CONNECTION_CLASS = 'fakeredis.FakeStrictRedis'
   

   rq = RQ()
   
   def create_app(config_name):
       app = Flask(__name__)
       app.config.from_object(config[config_name])
       rq.init_app(app)
   

   Where and how would it make sense to add the documentation? I would add a section in https://github.com/rq/Flask-RQ2/blob/master/docs/index.rst
6. jezdez commented on Sep 19, 2018

   

   jezdez

   on Sep 19, 2018

   Contributor

   More actions

   @moritz89 Yeah, adding something to docs/index.rst makes sense to me, as a "Testing" section?
7. moritz89 commented on Sep 19, 2018

   

   moritz89

   on Sep 19, 2018 via email

   ContributorAuthor

   More actions

   Totally forgot about it. I’ll send you an MR by the end of next week.

   …

   On 19. Sep 2018, at 10:25, Jannis Leidel ***@***.***> wrote: @moritz89 Yeah, adding something to docs/index.rst makes sense to me, as a "Testing" section? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.