Repository navigation
fix: preserve repeated empty tuples during traversal - #505
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
danielmorell
self-requested a review
October 23, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Empty built-in tuples share an identity. Memoizing that identity made later empty logging argument tuples become
CircularReferencestrings instead of empty JSON arrays. Skip memoizing only empty built-in tuples, while still invoking their handlers at each occurrence. Non-empty tuples and recursive containers retain the existing reference handling.Fixes #402.
Type of change
Validation
/tmpversus\tmppath assertion failed. The same failure was reproduced with the original traversal implementation. Optional framework integration suites were not run.mypy: no issues in 52 source files;git diff --checkpasses.Checklists