[BUGS-7105] check if the $output index is set before manipulating it#285
Merged
jazzsequence merged 3 commits intodevelopfrom Nov 13, 2023
Merged
[BUGS-7105] check if the $output index is set before manipulating it#285jazzsequence merged 3 commits intodevelopfrom
$output index is set before manipulating it#285jazzsequence merged 3 commits intodevelopfrom
Conversation
Contributor
Author
|
Behat tests will be fixed by #283 |
pwtyler
previously approved these changes
Nov 9, 2023
pwtyler
approved these changes
Nov 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #284 by ensuring that any
$outputindices exist before manipulating them (in the pattern$output['some_index'] + 1) which returns a PHP warning if that index does not exist.