Skip to content

Enhance informational Error message for the case of headers already sent #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jazzsequence merged 3 commits into from
May 30, 2023
Merged

Enhance informational Error message for the case of headers already sent #249

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20af6d7
Enhance informational Error message for the case of headers already sent
MiguelAxcar May 29, 2023
a0b10d3
Add textdomain & fix spacing
jazzsequence May 30, 2023
86fc363
fix spacing
jazzsequence May 30, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion pantheon-sessions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,21 @@ private function initialize_session_override() {
require_once __DIR__ . '/inc/class-session-handler.php';
$session_handler = new Pantheon_Sessions\Session_Handler();
if ( PHP_SESSION_ACTIVE !== session_status() ) {
session_set_save_handler( $session_handler, false );
// Check if headers have already been sent
if ( headers_sent( $file, $line ) ) {
// Output a friendly error message if headers are already sent
trigger_error(
sprintf(
/* translators: %1s: File path, %2d: Line number */
__( "Oops! The wp-native-php-sessions plugin couldn't start the session because output has already been sent. This might be caused by PHP throwing errors. Please check the code in %1s on line %2d.", 'wp-native-php-sessions' ),
$file,
$line
),
E_USER_WARNING
);
} else {
session_set_save_handler( $session_handler, false );
}
}
// Close the session before $wpdb destructs itself.
add_action( 'shutdown', 'session_write_close', 999, 0 );
Expand Down