Skip to content

Domain Path removed#168

Closed
pixelbart wants to merge 1 commit intopantheon-systems:masterfrom
pixelbart:patch-1
Closed

Domain Path removed#168
pixelbart wants to merge 1 commit intopantheon-systems:masterfrom
pixelbart:patch-1

Conversation

@pixelbart
Copy link

@pixelbart pixelbart commented Sep 16, 2020

The translations are currently not pulled through wordpress.org, so I removed the Domain Path.
@pixelbart
Domain Path removed
39200e7 
The translations are currently not pulled through wordpress.org, so I removed the Domain Path.
@danielbachhuber
Copy link
Contributor

danielbachhuber commented Sep 16, 2020

Thanks @pixelbart !

The translations are currently not pulled through wordpress.org

Sorry, not sure I follow what this means. Can you clarify?
@pixelbart
Copy link
Author

pixelbart commented Sep 17, 2020

Thanks @pixelbart !

The translations are currently not pulled through wordpress.org

Sorry, not sure I follow what this means. Can you clarify?

Thank you for your message!

I had made a German translation for the plugin, but the German translation is not displayed.

I assume that this is due to the domain path pointing to the /languages folder, although the translation is on wordpress.org.

I put the german translation on wordpress.org.

Stay healthy!
@danielbachhuber
Copy link
Contributor

danielbachhuber commented Sep 17, 2020

As it turns out, the more important thing I needed to do was rename the textdomain to match the WordPress.org slug for the plugin. I've done so with #169 and tagged v1.2.1. Your localization should now work for you.

Thanks for bringing this to my attention!
@pixelbart pixelbart deleted the patch-1 branch September 17, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@pixelbart @danielbachhuber