fix(formatter): print the idempotent placement for comments in dropped parens by leaysgur · Pull Request #26041 · oxc-project/oxc

leaysgur · 2026-08-24T07:50:26Z

Fixes non-idempotent formatting with comment and dropped parens.

leaysgur · 2026-08-24T07:50:39Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-08-24T07:55:06Z

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 19 skipped benchmarks¹

_{Comparing 08-24-fix_formatter_print_the_idempotent_placement_for_comments_in_dropped_parens (8e44ae6) with main (9b51658)²}

19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (faf11d9) during the generation of this report, so 9b51658 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

graphite-app · 2026-08-25T09:27:36Z

Merge activity

Aug 25, 9:27 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Aug 25, 9:32 AM UTC: Merged by the Graphite merge queue.

…d parens (#26041) Fixes non-idempotent formatting with comment and dropped parens.

# Oxlint ### 🚀 Features - 60b945d linter/nextjs/no-typos: Implement suggestion (#26091) (Mikhail Baev) ### 🐛 Bug Fixes - 33ac4b0 linter/lsp: Prevent tsgolint from holding onto processes (#25570) (Adrian Schaedle) - baf4b1e linter/import/no-empty-named-blocks: Make empty value import removal a suggestion (#26155) (camc314) - 77cfaec linter/eslint/object-shorthand: Preserve `__proto__` semantics (#26154) (camc314) - fa3c082 linter/unicorn/prefer-set-size: Ignore shadowed `Set` constructors (#26153) (camc314) - e412cf2 linter: Clamp invalid JS plugin locations (#26144) (camc314) - d86c113 linter: Normalize reversed JS plugin locations (#26138) (camc314) - 73c09b2 linter/eslint/no-use-before-define: Run on JS, JSX files (#26114) (camc314) - 03ef0f2 linter/unicorn/no-useless-spread: Treat typed arrays as a distinct value hint (#26067) (Aadharsh Pannirselvam) - bd15905 linter/react/no-unstable-nested-components: Check nested component object property names (#26101) (camc314) - 3910e2b linter/eslint/no-unassigned-vars: Skip Svelte and Vue files (#26042) (Hamody We) - 047f7ca linter/plugins: Fix interaction between JS plugins and Vue rules (#26080) (overlookmotel) - 8531b9b linter/plugins: Alter method for obtaining mutable `Program` when sending AST to JS plugins (#26077) (overlookmotel) - dc464ff linter/unicorn/prefer-math-min-max: Avoid unsafe autofix (#26060) (camc314) ### 📚 Documentation - 464ddd1 linter: Support a shared short description for jest/vitest rules (#26186) (connorshea) - 9db5ad3 linter: Add short description to `vue/no-dupe-keys` (#26183) (connorshea) - db66f58 linter: Correct export/import mismatch in bar and foo example (#25927) (billychannnnnn) - d5be037 linter/typescript/switch-exhaustiveness-check: Clarify default case comment pattern (#26100) (camc314) # Oxfmt ### 🚀 Features - 1fb37b6 formatter/css: Format declaration-shaped raw-prelude rules (postcss nested config blocks) (#26194) (leaysgur) ### 🐛 Bug Fixes - 57e8e22 formatter_css: Space a folded sign after a call in Less operations (#26134) (leaysgur) - e4298fb formatter/jsdoc: Follow CommonMark for interrupting lists and guard wrapping from creating them (#26098) (leaysgur) - a1e21c2 formatter: Apply head body policy everywhere (#26074) (leaysgur) - 676b7e1 formatter: Keep comments in their for-head slot, before an empty-statement body and do-while (#26073) (leaysgur) - 3bbcea6 formatter: Keep comments between a head and its body out of the braces across all constructs (#26071) (leaysgur) - 57537a2 formatter: Place comments between a head and open paren (#26058) (leaysgur) - e2d53e7 formatter: Place comments between a statement head and its body (#26043) (leaysgur) - 662556c formatter: Print the idempotent placement for comments in dropped parens (#26041) (leaysgur) - faf11d9 formatter_yaml: Keep trailing whitespace in block scalars (#26072) (leaysgur) ### ⚡ Performance - ac4785a diagnostics: Use fixed ANSI styles (#26130) (Boshen) ### 📚 Documentation - b879608 formatter,formatter_graphql,formatter_yaml: Annotate own-line comment inlining as known policy violation (#26131) (leaysgur) - 181953b oxfmt,formatter_core,formatter,formatter_yaml,formatter_css,formatter_graphql: Extract `DIVERGENCES.md` out from `AGENTS.md` (#26121) (leaysgur) - a67cb9d formatter,formatter_core: Document comment moving policy (#26075) (leaysgur) - fc175b0 formatter_core: Clarify idempotency test infra (#26069) (leaysgur)

leaysgur requested a review from overlookmotel as a code owner August 24, 2026 07:50

github-actions Bot added A-ast-tools Area - AST tools A-formatter Area - Formatter labels Aug 24, 2026

leaysgur force-pushed the 08-24-fix_formatter_print_the_idempotent_placement_for_comments_in_dropped_parens branch from 1227359 to 5466a4d Compare August 24, 2026 09:07

leaysgur mentioned this pull request Aug 24, 2026

fix(formatter): place comments between a statement head and its body #26043

Merged

leaysgur force-pushed the 08-24-fix_formatter_print_the_idempotent_placement_for_comments_in_dropped_parens branch from 5466a4d to 53444f1 Compare August 24, 2026 12:56

leaysgur mentioned this pull request Aug 24, 2026

fix(formatter): place comments between a head and open paren #26058

Merged

leaysgur force-pushed the 08-24-fix_formatter_print_the_idempotent_placement_for_comments_in_dropped_parens branch from 53444f1 to 2d9b3be Compare August 25, 2026 02:29

leaysgur mentioned this pull request Aug 25, 2026

fix(formatter): keep comments between a head and its body out of the braces across all constructs #26071

Merged

leaysgur force-pushed the 08-24-fix_formatter_print_the_idempotent_placement_for_comments_in_dropped_parens branch from 2d9b3be to cc65a5d Compare August 25, 2026 04:29

leaysgur mentioned this pull request Aug 25, 2026

fix(formatter): keep comments in their for-head slot, before an empty-statement body and do-while #26073

Merged

leaysgur force-pushed the 08-24-fix_formatter_print_the_idempotent_placement_for_comments_in_dropped_parens branch from cc65a5d to 8e44ae6 Compare August 25, 2026 05:02

This was referenced Aug 25, 2026

fix(formatter): apply head body policy everywhere #26074

Merged

docs(formatter,formatter_core): document comment moving policy #26075

Merged

graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Aug 25, 2026

fix(formatter): print the idempotent placement for comments in droppe…

662556c

…d parens (#26041) Fixes non-idempotent formatting with comment and dropped parens.

graphite-app Bot force-pushed the 08-24-fix_formatter_print_the_idempotent_placement_for_comments_in_dropped_parens branch from 8e44ae6 to 662556c Compare August 25, 2026 09:28

graphite-app Bot merged commit 662556c into main Aug 25, 2026
31 checks passed

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Aug 25, 2026

graphite-app Bot deleted the 08-24-fix_formatter_print_the_idempotent_placement_for_comments_in_dropped_parens branch August 25, 2026 09:32

oxc-guard Bot mentioned this pull request Aug 31, 2026

release(apps): oxlint v1.81.0 && oxfmt v0.66.0 #26199

Merged

Navigation Menu

Uh oh!

Uh oh!

fix(formatter): print the idempotent placement for comments in dropped parens - #26041

fix(formatter): print the idempotent placement for comments in dropped parens#26041
graphite-app[bot] merged 1 commit into
mainfrom
08-24-fix_formatter_print_the_idempotent_placement_for_comments_in_dropped_parens

leaysgur commented Aug 24, 2026

leaysgur commented Aug 24, 2026 •

edited

Loading

codspeed-hq Bot commented Aug 24, 2026 •

edited

Loading

graphite-app Bot commented Aug 25, 2026 •

edited

Loading

Uh oh!

Labels

1 participant

Uh oh!

Uh oh!

Conversation

leaysgur commented Aug 24, 2026

leaysgur commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

codspeed-hq Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

graphite-app Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Labels

1 participant

leaysgur commented Aug 24, 2026 •

edited

Loading

codspeed-hq Bot commented Aug 24, 2026 •

edited

Loading

graphite-app Bot commented Aug 25, 2026 •

edited

Loading