fix(react_compiler): preserve nonfatal diagnostics - #25066
Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
Boshen
force-pushed
the
fix/react-compiler-nonfatal-diagnostics
branch
from
July 29, 2026 11:17
8e20166 to
d14f411
Compare
Boshen
force-pushed
the
fix/react-compiler-nonfatal-diagnostics
branch
from
July 29, 2026 11:18
d14f411 to
41a61d2
Compare
Boshen
marked this pull request as ready for review
July 29, 2026 12:29
Member
Author
Merge activity
|
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41a61d2aa2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
graphite-app Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
Preserves nonfatal React Compiler diagnostics and covers warning bailouts through the N-API binding. AI-assisted.
graphite-app
Bot
force-pushed
the
fix/react-compiler-nonfatal-diagnostics
branch
from
July 29, 2026 12:35
41a61d2 to
2117940
Compare
Boshen
force-pushed
the
fix/react-compiler-nonfatal-diagnostics
branch
from
July 29, 2026 13:03
2117940 to
57511e4
Compare
Preserves nonfatal React Compiler diagnostics and covers warning bailouts through the N-API binding. AI-assisted.
graphite-app
Bot
force-pushed
the
fix/react-compiler-nonfatal-diagnostics
branch
from
July 29, 2026 13:09
57511e4 to
5d8ccf5
Compare
This was referenced Aug 3, 2026
graphite-app Bot
pushed a commit
that referenced
this pull request
Aug 3, 2026
### 💥 BREAKING CHANGES - 4120da0 semantic: [**BREAKING**] Return borrowed JSDoc so the parse cache works (#25186) (Connor Shea) - f0a41c8 allocator: [**BREAKING**] Remove `ArenaBox::dangling` method (#25236) (overlookmotel) - 067da8c ast: [**BREAKING**] Store single parameter in `TSIndexSignature::parameter` (#25154) (camc314) - a0c7788 ast: [**BREAKING**] Change `TSIndexSignatureName::name` to `Ident` (#25150) (camc314) - 1bdedd1 ast: [**BREAKING**] Introduce `ExportDeclaration`, `ExportFromDeclaration` (#25095) (camc314) - c917f20 ast: [**BREAKING**] Introduce `ArrowFunctionBody` enum (#24987) (camc314) - 7e1199c ast: [**BREAKING**] Remove conversion to `Box` from AST builder methods (#25038) (overlookmotel) ### 🚀 Features - 3c8312e allocator: Make `Box` `Send` + `Sync` when the type it contains is (#25242) (overlookmotel) - cb5bc08 ast: Derive `GetSpan` for `Comment` (#25147) (leaysgur) - 8541e18 ast_tools: Generate minifier scope collector (#25088) (camc314) - 5acdae2 ecmascript: Skip transparent TS expressions (#25072) (camc314) - 85d0f4d napi: Add React Compiler transform binding (#24934) (Boshen) - 70d6ece minifier: Fold safe integer exponentiation (#25009) (Dunqing) - 73fc747 minifier: Enable termination statement optimization for do while (#24921) (Armano) - 5eadfdb minifier: Fold safe integer division and remainder (#24981) (Dunqing) ### 🐛 Bug Fixes - 6c9ee14 minifier: Preserve if-chain idempotency and correct side effects when alternate should not be moved (#25041) (Armano) - 8a47ff3 ecmascript: Do not treat lone-surrogate strings as constants (#25084) (Dunqing) - 468b970 isolated-declarations: Strip re-export attributes (#25090) (camc314) - a70035d parser: Report export imports in namespaces (#25086) (camc314) - 5d8ccf5 react_compiler: Preserve nonfatal diagnostics (#25066) (Boshen) - d349e4a react_compiler: Match eslint suppression gating (#25068) (Boshen) - 0dc16ba react_compiler: Track catch block declarations (#25067) (Boshen) - e6734a5 minifier: Fold typeof comparisons with known object strings (#25017) (Dunqing) - 3a9d5a5 minifier: Keep `typeof foo == ['object']` as-is (#24941) (sapphi-red) - 10ec276 ast: Custom AST builder methods take `IntoIn<ArenaBox>` where child method does (#25033) (overlookmotel) - fbe8d31 minifier: Respect targets when folding RegExp source (#24790) (Dunqing) ### ⚡ Performance - fb402b0 minifier: Stop re-deriving printed numeric spellings (#25103) (Dunqing) - 7251e52 react_compiler: Avoid large types on stack (#25037) (overlookmotel) - e07718f isolated_declarations: Avoid large types on stack (#25036) (overlookmotel) - 9fb1e3e transformer: Avoid large types on stack (#25035) (overlookmotel) - 8b80f8b parser: Avoid large types on stack (#25034) (overlookmotel) ### 📚 Documentation - 2ea0aa9 ast: Correct grammar in AST builder methods doc comments (#25173) (overlookmotel)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves nonfatal React Compiler diagnostics and covers warning bailouts through the N-API binding.
AI-assisted.