fix: update Hono security patches - #2620
Conversation
|
@irontaek is attempting to deploy a commit to the OpenStatus Team on Vercel. A member of the Team first needs to authorize it. |
f73401e to
fc6bc33
Compare
|
CI note: the first run passed the API job, while the server job failed during test cleanup with All other GitHub checks passed, and the failure moved between unrelated suites without a code change. Could a maintainer rerun the failed Tests workflow? The three Vercel statuses also report |
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
fc6bc33 to
1feeecd
Compare
|
Addressed in 1feeecd: the Hono override now uses |
|
@claude review this |
|
Claude finished @thibaultleouay's task in 55s —— View job Review
Summary: This is a clean, well-scoped security patch bump. I verified the specific claims made in the PR description rather than taking them at face value:
No correctness or security issues found. The changes are minimal and scoped exactly to what the description claims (catalog bump, node-server pin, override for transitive copies). |
Summary
@hono/node-serverto the patched 1.19.15 releaseSecurity impact
The server currently uses
cors()with default options in:apps/server/src/routes/public/index.tsapps/server/src/routes/v1/index.tsHono 4.12.21 reaches the vulnerable default
allowHeaderspath described in GHSA-8j4g-w8fx-2239, where an unauthenticated preflight request can trigger quadratic header parsing and consume disproportionate CPU.The lockfile also retained vulnerable Hono and Node adapter copies through
@modelcontextprotocol/sdk. The overrides keep all workspace and transitive copies on patched releases.Verification
pnpm audit --prod: Hono /@hono/node-serveradvisories 15 → 0 (2 high, 12 moderate, 1 low removed)pnpm install --frozen-lockfile --lockfile-onlypnpm verifywith the repository-pinned Node 24.12.0 and Deno 2.9.4: 39/39 packages passedThe lockfile change is intentional and contains only the Hono resolution and peer snapshot updates required by these overrides.