Skip to content

doc: update teams in collaborator-guide.md and add links - #60065

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
louwers:patch-1
Oct 11, 2025
Merged

doc: update teams in collaborator-guide.md and add links#60065
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
louwers:patch-1

Conversation

@louwers

@louwers louwers commented Sep 28, 2025

Copy link
Copy Markdown
Contributor
  • Remove @nodejs/modules, team does not exist
  • Remove @nodejs/util
  • Add @nodejs/sqlite
  • Add links
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Sep 28, 2025
@aduh95

aduh95 commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Those links makes the document very hard to read, if we're adding them (and tbh, I'm not sure it's worth it), we would want to add references at the end of the file (i.e. [@nodejs/team][] in the table and [@nodejs/team]: https://… at EOF)

@louwers

louwers commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

@aduh95 Good call!

@louwers

louwers commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

@aduh95 Please have another look, thanks!

Comment thread doc/contributing/collaborator-guide.md Outdated
@louwers

louwers commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

cc @bnoordhuis @indutny @mscdex @rvagg removing your names from the collaborator guide, please join a team instead if you want to be pinged.

@louwers
louwers requested review from aduh95 and rvagg October 8, 2025 11:01
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 11, 2025
@nodejs-github-bot
nodejs-github-bot merged commit a2f088d into nodejs:main Oct 11, 2025
26 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a2f088d

aduh95 pushed a commit that referenced this pull request Oct 31, 2025
PR-URL: #60065
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
PR-URL: #60065
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
PR-URL: #60065
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 mentioned this pull request Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation.

5 participants