Skip to content

test: add Float16Array to common.getArrayBufferViews() - #58233

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-getarraybufferviews-float16
May 10, 2025
Merged

test: add Float16Array to common.getArrayBufferViews()#58233
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-getarraybufferviews-float16

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented May 8, 2025

Copy link
Copy Markdown
Member

No description provided.

@LiviaMedeiros LiviaMedeiros added test Issues and PRs related to Node.js core tests and test infrastructure. dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels May 8, 2025
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 8, 2025
@nodejs-github-bot

nodejs-github-bot commented May 8, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66709/
@codecov

codecov Bot commented May 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (535c2f7) to head (3738447).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58233      +/-   ##
==========================================
+ Coverage   90.12%   90.14%   +0.02%     
==========================================
  Files         629      629              
  Lines      186638   186638              
  Branches    36618    36620       +2     
==========================================
+ Hits       168202   168244      +42     
+ Misses      11222    11208      -14     
+ Partials     7214     7186      -28

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 9, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66733/
@LiviaMedeiros LiviaMedeiros added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 10, 2025
@nodejs-github-bot
nodejs-github-bot merged commit f8809ce into nodejs:main May 10, 2025
@nodejs-github-bot

nodejs-github-bot commented May 10, 2025

Copy link
Copy Markdown
Collaborator

Landed in f8809ce
targos pushed a commit that referenced this pull request May 16, 2025
@LiviaMedeiros @targos
test: add Float16Array to common.getArrayBufferViews()
97f8037 
PR-URL: #58233
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions Bot mentioned this pull request May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

6 participants

@LiviaMedeiros @nodejs-github-bot @lpinca @targos @cjihrig @atlowChemi