tools: update eslint to 8.36.0 - #47046
Merged
Merged
Conversation
Trott
approved these changes
Mar 12, 2023
MoLow
approved these changes
Mar 12, 2023
MoLow
added
the
commit-queue
anonrig
approved these changes
Mar 12, 2023
lpinca
approved these changes
Mar 12, 2023
cjihrig
approved these changes
Mar 13, 2023
nodejs-github-bot
added
commit-queue-failed
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/47046 ✔ Done loading data for nodejs/node/pull/47046 ----------------------------------- PR info ------------------------------------ Title tools: update eslint to 8.36.0 (#47046) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-eslint -> nodejs:main Labels tools Commits 2 - tools: update eslint to 8.36.0 - tools: update eslint to 8.36.0 Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/47046 Reviewed-By: Rich Trott Reviewed-By: Moshe Atlow Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47046 Reviewed-By: Rich Trott Reviewed-By: Moshe Atlow Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: update eslint to 8.36.0 ℹ This PR was created on Sun, 12 Mar 2023 00:28:24 GMT ✔ Approvals: 5 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47046#pullrequestreview-1335948613 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47046#pullrequestreview-1335963574 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47046#pullrequestreview-1335966215 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47046#pullrequestreview-1335967651 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47046#pullrequestreview-1336182103 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4410989878 |
MoLow
approved these changes
Mar 14, 2023
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/47046
✔ Done loading data for nodejs/node/pull/47046
----------------------------------- PR info ------------------------------------
Title tools: update eslint to 8.36.0 (#47046)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch nodejs-github-bot:actions/tools-update-eslint -> nodejs:main
Labels tools
Commits 2
- tools: update eslint to 8.36.0
- tools: update eslint to 8.36.0
Committers 1
- Node.js GitHub Bot
PR-URL: https://github.com/nodejs/node/pull/47046
Reviewed-By: Rich Trott
Reviewed-By: Moshe Atlow
Reviewed-By: Yagiz Nizipli
Reviewed-By: Luigi Pinca
Reviewed-By: Colin Ihrig
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47046
Reviewed-By: Rich Trott
Reviewed-By: Moshe Atlow
Reviewed-By: Yagiz Nizipli
Reviewed-By: Luigi Pinca
Reviewed-By: Colin Ihrig
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 12 Mar 2023 00:28:24 GMT
✔ Approvals: 5
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47046#pullrequestreview-1335948613
✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47046#pullrequestreview-1338718407
✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47046#pullrequestreview-1335966215
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47046#pullrequestreview-1335967651
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47046#pullrequestreview-1336182103
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 47046
From https://github.com/nodejs/node
* branch refs/pull/47046/merge -> FETCH_HEAD
✔ Fetched commits as f41d50786286..1da9ecd32324
--------------------------------------------------------------------------------
[main fd03fdbbbf] tools: update eslint to 8.36.0
Date: Sun Mar 12 00:28:20 2023 +0000
863 files changed, 1906 insertions(+), 2448 deletions(-)
rename tools/node_modules/eslint/node_modules/{ => @eslint-community}/eslint-utils/LICENSE (100%)
rename tools/node_modules/eslint/node_modules/{ => @eslint-community}/eslint-utils/index.js (98%)
rename tools/node_modules/eslint/node_modules/{ => @eslint-community}/eslint-utils/index.mjs (98%)
create mode 100644 tools/node_modules/eslint/node_modules/@eslint-community/eslint-utils/package.json
rename tools/node_modules/eslint/node_modules/{ => @eslint-community}/regexpp/LICENSE (100%)
rename tools/node_modules/eslint/node_modules/{ => @eslint-community}/regexpp/index.js (77%)
rename tools/node_modules/eslint/node_modules/{ => @eslint-community}/regexpp/index.mjs (77%)
rename tools/node_modules/eslint/node_modules/{ => @eslint-community}/regexpp/package.json (56%)
create mode 100644 tools/node_modules/eslint/node_modules/caniuse-lite/data/features/css-text-box-trim.js
delete mode 100644 tools/node_modules/eslint/node_modules/eslint-utils/node_modules/eslint-visitor-keys/LICENSE
delete mode 100644 tools/node_modules/eslint/node_modules/eslint-utils/node_modules/eslint-visitor-keys/lib/index.js
delete mode 100644 tools/node_modules/eslint/node_modules/eslint-utils/node_modules/eslint-visitor-keys/lib/visitor-keys.json
delete mode 100644 tools/node_modules/eslint/node_modules/eslint-utils/node_modules/eslint-visitor-keys/package.json
delete mode 100644 tools/node_modules/eslint/node_modules/eslint-utils/package.json
[main 6af79e64da] tools: update eslint to 8.36.0
Date: Mon Mar 13 11:30:25 2023 +0000
4 files changed, 4 insertions(+), 4 deletions(-)
✔ Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
https://github.com/nodejs/node/actions/runs/4413777050 |
nodejs-github-bot
added
the
commit-queue-failed
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
|
Landed in aa93c8b |
targos
pushed a commit
that referenced
this pull request
Mar 18, 2023
PR-URL: #47046 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 3, 2023
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47046 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of eslint to 8.36.0.