Skip to content

doc: remove cjihrig from TC - #1056

Closed
cjihrig wants to merge 1 commit into
nodejs:v1.xfrom
cjihrig:tc
Closed

doc: remove cjihrig from TC#1056
cjihrig wants to merge 1 commit into
nodejs:v1.xfrom
cjihrig:tc

Conversation

@cjihrig

@cjihrig cjihrig commented Mar 4, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@bnoordhuis

bnoordhuis commented Mar 4, 2015

Copy link
Copy Markdown
Member

LGTM but what prompted it?
@cjihrig

cjihrig commented Mar 4, 2015

Copy link
Copy Markdown
Contributor Author

Only that I haven't felt like I've had a ton to contribute to the meetings, and that I'd like to reclaim some time, since I'm balancing this with my full time job. I also want to make it clear that I still support the TC and the way the project is run, and am not stepping down for any negative reasons. I still plan to work as a collaborator, if you will have me of course.
@bnoordhuis

bnoordhuis commented Mar 4, 2015

Copy link
Copy Markdown
Member

Of course. :-) I just wondered if something bad had happened. Happy to hear that's not the case.
cjihrig added a commit that referenced this pull request Mar 4, 2015
@cjihrig
doc: remove cjihrig from TC
6190a22 
PR-URL: #1056
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@cjihrig

cjihrig commented Mar 4, 2015

Copy link
Copy Markdown
Contributor Author

Thanks! Landed in 6190a22
@cjihrig cjihrig closed this Mar 4, 2015
@cjihrig
cjihrig deleted the tc branch March 4, 2015 15:42
@rvagg rvagg mentioned this pull request Mar 4, 2015
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 24, 2023
Open
@aliscco aliscco mentioned this pull request Nov 30, 2023
Open
Renegade334 pushed a commit to Renegade334/node that referenced this pull request Jun 24, 2026
@dankmeme01 @Renegade334
deps: c-ares: cherry-pick 8ba37af8e3fb
4aaa35c 
Original commit message:

    Fixes nodejs#1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
nodejs-github-bot pushed a commit that referenced this pull request Jun 26, 2026
@Renegade334
deps: c-ares: cherry-pick 8ba37af8e3fb
b48e4cd 
Original commit message:

    Fixes #1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: #64110
Fixes: #62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 3, 2026
@Renegade334 @richardlau
deps: c-ares: cherry-pick 8ba37af8e3fb
c7e57f5 
Original commit message:

    Fixes #1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: #64110
Fixes: #62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 8, 2026
@Renegade334 @aduh95
deps: c-ares: cherry-pick 8ba37af8e3fb
5568d6e 
Original commit message:

    Fixes #1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: #64110
Fixes: #62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 19, 2026
@Renegade334 @juanarbol
deps: c-ares: cherry-pick 8ba37af8e3fb
70f68a4 
Original commit message:

    Fixes nodejs#1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: nodejs#64110
Fixes: nodejs#62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit that referenced this pull request Jul 19, 2026
@Renegade334 @juanarbol
deps: c-ares: cherry-pick 8ba37af8e3fb
0b80ea3 
Original commit message:

    Fixes #1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: #64110
Fixes: #62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@Renegade334 @aduh95
deps: c-ares: cherry-pick 8ba37af8e3fb
1078da9 
Original commit message:

    Fixes #1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: #64110
Fixes: #62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@Renegade334 @aduh95
deps: c-ares: cherry-pick 8ba37af8e3fb
3cdcace 
Original commit message:

    Fixes #1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: #64110
Fixes: #62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 29, 2026
@Renegade334 @marco-ippolito
deps: c-ares: cherry-pick 8ba37af8e3fb
8d9f178 
Original commit message:

    Fixes #1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: #64110
Fixes: #62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@Renegade334 @aduh95
deps: c-ares: cherry-pick 8ba37af8e3fb
dc78091 
Original commit message:

    Fixes #1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: #64110
Fixes: #62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit that referenced this pull request Aug 20, 2026
@Renegade334 @juanarbol
deps: c-ares: cherry-pick 8ba37af8e3fb
4ca6a50 
Original commit message:

    Fixes #1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: #64110
Fixes: #62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol pushed a commit that referenced this pull request Aug 21, 2026
@Renegade334 @juanarbol
deps: c-ares: cherry-pick 8ba37af8e3fb
01855a1 
Original commit message:

    Fixes #1056

    The commit
    c-ares/c-ares@1d1b3d4
    refactored the function to use wide strings, but didn't touch this
    check. Because an empty wide string would now be size 2 and not 1, the
    empty string would go on and cause the DNS domain list to be replaced
    with nothing.

    Signed-off-by: @dankmeme01

Refs: c-ares/c-ares@8ba37af
PR-URL: #64110
Fixes: #62347
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@cjihrig @bnoordhuis