Skip to content

Add submitted pings table - #3585

Open
jeddai wants to merge 22 commits into
mozilla:mainfrom
jeddai:add-submitted_pings-table
Open

Add submitted pings table#3585
jeddai wants to merge 22 commits into
mozilla:mainfrom
jeddai:add-submitted_pings-table

Conversation

@jeddai

@jeddai jeddai commented Aug 11, 2026

Copy link
Copy Markdown
Member

Re-opening from #3575
@jeddai
jeddai requested a review from badboy August 11, 2026 13:58
@jeddai jeddai self-assigned this Aug 11, 2026
@jeddai
jeddai requested a review from a team as a code owner August 11, 2026 13:58
@jeddai

jeddai commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

Some changes:

  • Updated the PR to not require the time module for rusqlite by using Integers to store the dates
  • Added the mechanism to actually store the pings when they're submitted (still need to test this)
badboy
badboy requested changes Aug 14, 2026
View reviewed changes

@badboy badboy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is starting to look pretty good (did a full review this time).
A few more things.

Right now getting those pings back from the outside is not implemented, but I assume that's gonna be done in a followup?
Comment thread glean-core/src/database/sqlite/schema.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/metrics/ping.rs Outdated
badboy and others added 21 commits August 21, 2026 13:53
@badboy @jeddai
Put some state about the migration INTO the database
de287fa
@jeddai
Bug 2060553: Add submitted_pings database table and add get/store met…
73383e8 
…hods
@jeddai
update glean-sym-test Cargo.lock
b3c042b
@jeddai
update CHANGELOG.md
ebe93b5
@jeddai
fix where create and migrate diverged
b4aaead
@jeddai
adjust test to account for re-insert
5ab6f40
@jeddai
update based on feedback
d730fe9
@jeddai
fix issue with insert query
4ca57be
@jeddai
update changelog and fix rebase issue
d1d7d76
@jeddai
update Glean to have configuration options for enabling storing pings
df19ff6
@jeddai
fix formatting
041669f
@jeddai
add cleanup method that runs on shutdown/maintenance
2ad08c5
@jeddai
add variables and things to rlb
9a576be
@jeddai
set default value for enable_store_submitted_pings in InternalConfigu…
cff6f4c 
…ration UDL
@jeddai
update based on feedback
4a7abb3
@jeddai
uv.lock changes
7c4958d
@jeddai
update glean-sym-test Cargo.lock
4b6ea97
@jeddai
add method to lib to clear the stored submitted pings
ddd3c53 
# Conflicts:
#	glean-core/benchmark/benches/dispatcher.rs
#	glean-core/benchmark/benches/lifetime_buffering.rs
@jeddai
update based on feedback
af30910
@jeddai
add FFI/RLB methods to retrieve stored submitted pings from database
296d68e
@jeddai
update changelog
0f436f4
@jeddai
jeddai force-pushed the add-submitted_pings-table branch from edced9d to 0f436f4 Compare August 21, 2026 19:05
@jeddai
jeddai requested a review from badboy August 24, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jeddai @badboy