Add exclude_ratings parameter to the ratings API#9552
Merged
diox merged 1 commit intomozilla:masterfrom Oct 1, 2018
Merged
Conversation
eviljeff
reviewed
Sep 29, 2018
docs/topics/api/overview.rst
Outdated
Member
There was a problem hiding this comment.
But... we don't need to backport anymore do we? Frontend moved to v4
Member
Author
There was a problem hiding this comment.
It was more annoying not to backport it, since it's just an additional query parameter
Member
There was a problem hiding this comment.
heh, yeah. Thought we should consider if our current "one gate per minor feature change" strategy is too heavy for non-breaking changes like this. Maybe we could have a generic "exclude_v4_rating_features" feature-gate or similar that would .hide all the new stuff we're adding in v4 from v3?
EnTeQuAk
approved these changes
Oct 1, 2018
diox
force-pushed
the
api-exclude-ratings-parameter
branch
from
ea04bea to
e6dcc90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mozilla/addons#5984