add api feature gates (+ reviews shim as example case)#8332
Merged
eviljeff merged 2 commits intomozilla:masterfrom May 25, 2018
Merged
add api feature gates (+ reviews shim as example case)#8332eviljeff merged 2 commits intomozilla:masterfrom
eviljeff merged 2 commits intomozilla:masterfrom
Conversation
EnTeQuAk
approved these changes
May 25, 2018
Contributor
EnTeQuAk
left a comment
EnTeQuAk
left a comment
There was a problem hiding this comment.
Does look great to me. Thanks for taking my api-gates gist into account!
eviljeff
force-pushed
the
8255-api-feature-gates
branch
from
b59649a to
9ff34b0
Compare
eviljeff
added a commit
to eviljeff/olympia
that referenced
this pull request
May 25, 2018
eviljeff
added a commit
that referenced
this pull request
May 25, 2018
9 tasks
willdurand
added a commit
to mozilla/addons-frontend
that referenced
this pull request
Sep 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes mozilla/addons#5510 (and does part of mozilla/addons#4984 that isn't implemented in #8303)