drop heading, heading_text, description from discovery api#15856
Merged
eviljeff merged 3 commits intomozilla:masterfrom Oct 29, 2020
Merged
drop heading, heading_text, description from discovery api#15856eviljeff merged 3 commits intomozilla:masterfrom
eviljeff merged 3 commits intomozilla:masterfrom
Conversation
eviljeff
requested review from
a team and
diox
and removed request for
a team
eviljeff
commented
Oct 28, 2020
src/olympia/lib/settings_base.py
Outdated
| 'addons-search-_score-field', | ||
| 'ratings-can_reply', | ||
| 'ratings-score-filter', | ||
| 'disco-heading-and-description-shim', |
Member
Author
There was a problem hiding this comment.
I wasn't intending to have this gate for v4 but it's safest while we've still got the old discovery frontend deploy hanging around that consumes it.
Member
There was a problem hiding this comment.
I think it's safe to remove that given that https://bugzilla.mozilla.org/show_bug.cgi?id=1673924 has been fixed on -dev/-stage.
diox
approved these changes
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes mozilla/addons#6595