Repository navigation
Conversation
| * @mongodb-labs/dbx-drivers-tools-maintainers | ||
|
|
||
| # Language-specific actions are owned by the relevant language team | ||
| /golang/ @mongodb-labs/dbx-go |
Collaborator
There was a problem hiding this comment.
This would change golang membership to just dbx-go, and would drop the maintainers. Is that what we want?
If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.
If the goal is to add the Go team as reviewers AND keep the maintainers, this line should become:
/golang/ @mongodb-labs/dbx-go @mongodb-labs/dbx-drivers-tools-maintainers
(This applies to the rest, of course.)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Language-specific folders now have their language team as codeowner, so the repo maintainers are not the only reviewers for them. Shared actions and everything else stay with @mongodb-labs/dbx-drivers-tools-maintainers.
*(default)/golang//node//python/,/python-labs//ruby/Note
Need to be granted write access for these rules to take effect:
dbx-godbx-nodedbx-pythondbx-ruby