Skip to content

Route language-specific folders to language teams in CODEOWNERS - #150

Open
Jibola wants to merge 2 commits into
mainfrom
codeowners-language-teams
Open

Jibola wants to merge 2 commits into
mainfrom
codeowners-language-teams

Conversation

@Jibola

@Jibola Jibola commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Language-specific folders now have their language team as codeowner, so the repo maintainers are not the only reviewers for them. Shared actions and everything else stay with @mongodb-labs/dbx-drivers-tools-maintainers.

Path Owner
* (default) @mongodb-labs/dbx-drivers-tools-maintainers
/golang/ @mongodb-labs/dbx-go
/node/ @mongodb-labs/dbx-node
/python/, /python-labs/ @mongodb-labs/dbx-python
/ruby/ @mongodb-labs/dbx-ruby

Note

Need to be granted write access for these rules to take effect:

  • dbx-go
  • dbx-node
  • dbx-python
  • dbx-ruby
@Jibola
Jibola requested a review from a team as a code owner October 28, 2026 14:59
@Jibola
Jibola requested a review from papafe October 28, 2026 15:00
Comment thread .github/CODEOWNERS
* @mongodb-labs/dbx-drivers-tools-maintainers

# Language-specific actions are owned by the relevant language team
/golang/ @mongodb-labs/dbx-go

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would change golang membership to just dbx-go, and would drop the maintainers. Is that what we want?

Per https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax:

If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.

If the goal is to add the Go team as reviewers AND keep the maintainers, this line should become:

/golang/ @mongodb-labs/dbx-go @mongodb-labs/dbx-drivers-tools-maintainers

(This applies to the rest, of course.)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants