Repository navigation
Encode supplementary characters in reserved URI template expansion - #1931
Open
pournasserian wants to merge 5 commits into
Open
pournasserian wants to merge 5 commits into
pournasserian wants to merge 5 commits into
Conversation
Reserved ({+var}) and fragment ({#var}) expansion built a Rune from each
UTF-16 char, which throws for a surrogate half. Encode the full surrogate
pair as one UTF-8 scalar instead.
Fixes modelcontextprotocol#1913
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1913
Reserved (
{+var}) and fragment ({#var}) expansion inUriTemplate.Encodebuilt aRunefrom each UTF-16char. For a surrogate pair (for example, an emoji), that throwsArgumentOutOfRangeException. On netstandard2.0 it didn't throw, but each half was encoded as U+FFFD. The encoder now encodes the full pair as one UTF-8 scalar.Tests: added
ReservedExpansion_EncodesSupplementaryUnicodeScalarcovering{+},{#}and mixed BMP/supplementary values. It fails without the fix and passes with it on net10.0, net9.0, net8.0 and net472.