Fix: Don't ignore the indent settings in advanced wrapping mode#134171
Merged
alexdima merged 3 commits intomicrosoft:mainfrom Oct 27, 2021
Merged
Fix: Don't ignore the indent settings in advanced wrapping mode#134171alexdima merged 3 commits intomicrosoft:mainfrom
alexdima merged 3 commits intomicrosoft:mainfrom
Conversation
Fixes microsoft#132220 Fixes microsoft#120844 This still works in one pass by using negative text-indent with matching padding to generate a CSS-based hanging indent that we can measure. This could be upgraded to the `hanging` modifier in the far future.
Contributor
Author
|
Text I used to verify this fix (I didn't see any advanced wrapping test file): W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W
i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i
This is a normal long line that has normal words on it. No abnormal words here, though maybe that last one could count as one.
Very wide glyphs:
𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒈓 𒍼 𒅃 𒌧 𒈓 𒍼
𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫
﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽
Above is U+12143, U+12213, U+1237C, U+12327 (Cuneiform block characters), then U+1242B (CUNEIFORM NUMERIC SIGN NINE SHAR2), then finally U+FDFD (ARABIC LIGATURE BISMILLAH AR-RAHMAN AR-RAHEEM)
Screenshots of correctly wrapping & indenting with this change: |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR fixes #132220
and
This PR fixes #120844
This still works in one pass by using negative text-indent with matching
padding to generate a CSS-based hanging indent that we can measure.
This could be upgraded to the
hangingmodifier in the far future. (No browsers support it at this time)