Integrate Source Code into Disassembly View

[yuehuang010]

Feature: Integrate Source Code into Disassembly View

• Add Toggle Action to Show/Hide source code.
• Go-To-Source with line number on double click.
• Fix line-height to be more precise and default to match Monaco's default.
• Fixed remove all bp in the BP View to also remove Instruction Breakpoints.
• Fixed an issue when scrolling too fast to incorrectly load the wrong disassembly.

This PR fixes some of the issues in #129762

[yuehuang010]

@isidorn @roblourens

[weinand]

@yuehuang010 while reviewing and verifying the PR, I noticed that I can only set a breakpoint in a disassembly line that has the yellow current location:

This must be bug and not the expected behavior, right?

[yuehuang010]

@weinand I got a repro, thanks. The click box is squashed due to "flex-end". I need to investigate an alternative. Fixed.

[weinand]

@yuehuang010 thanks, setting breakpoints works now.

[weinand]

@yuehuang010 @roblourens in order to verify the "Show/Hide source code" feature I've added "source/line" attributes to disassembly instructions in Mock Debug (published on the Marketplace): the first instruction from a new source line has a corresponding "source/line" attribute:

I noticed a few things:

• the "Show/Hide source code" command is not discoverable, e.g. there is no context menu or editor action. Only clicking in an instruction with source will show the source.
• the "Show source code" does not seem to reveal/highlight the correct source line. Only the correct source editor is opened/revealed.
• hitting an instruction breakpoint sometimes reveals the line at the top of the view port which results in back and forth jumping:
  

[yuehuang010]

the "Show/Hide source code" command is not discoverable, e.g. there is no context menu or editor action. Only clicking in an > instruction with source will show the source.
A context menu is planned but out of scope for this PR. So I added other means like F1 command and Settings UI. This and copy and paste would be added once a context menu is added.

the "Show source code" does not seem to reveal/highlight the correct source line. Only the correct source editor is opened/revealed.
Did you supply add column information? It should select the span. Without column it would jump to line without selection.

@weinand

[weinand]

No, I did not provide a column, only the line. But even the line is not selected.

[yuehuang010]

@weinand , just pushed two fixes. The the entire line is selected on open file and stepping should reveal/follow new address.

[yuehuang010]

@roblourens Do you have any questions?

[roblourens]

horizontal scrolling is not working correctly for me

[xisui-MSFT]

horizontal scrolling is not working correctly for me

@yuehuang010 Horizontal scrolling has never been supported by WorkbenchTable. Please disable it.

[yuehuang010]

horizontal scrolling is not working correctly for me

@yuehuang010 Horizontal scrolling has never been supported by WorkbenchTable. Please disable it.

I missed reverting when testing.

[yuehuang010]

@roblourens @weinand @isidorn Could you please review this?

[roblourens]

Just the two remaining open discussions - when those are resolved, I can merge it. Would like to do that this week :)

[yuehuang010]

Just the two remaining open discussions - when those are resolved, I can merge it. Would like to do that this week :)

Pushed.