Skip to content

fix(58145): suppress jsdoc for private members - #64106

Open
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
microsoft:mainfrom
a-tarasyuk:fix/58145
Open

fix(58145): suppress jsdoc for private members#64106
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
microsoft:mainfrom
a-tarasyuk:fix/58145

Conversation

@a-tarasyuk

Copy link
Copy Markdown
Contributor

Fixes #58145

Copilot AI balanced review requested due to automatic review settings August 31, 2026 05:38
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Aug 31, 2026
@typescript-automation typescript-automation Bot added the For Backlog Bug PRs that fix a backlog bug label Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Suppresses JSDoc from type-erased private class members during declaration emit.

Changes:

  • Adds comment suppression for private properties, methods, and accessors.
  • Adds regression coverage and updates declaration baselines.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tsc/internal/transformers/declarations/transform.go Suppresses comments on emitted private members.
tsc/testdata/tests/cases/compiler/declarationEmitPrivateMemberComments.ts Tests TypeScript and JavaScript private members.
tsc/testdata/baselines/reference/compiler/declarationEmitPrivateMemberComments.js Captures declaration output.
tsc/testdata/baselines/reference/compiler/declarationEmitPrivateMemberComments.symbols Captures symbol output.
tsc/testdata/baselines/reference/compiler/declarationEmitPrivateMemberComments.types Captures type output.
tsc/testdata/baselines/reference/compiler/jsDeclarationEmitPrivateStaticMethod.js Updates private static method output.
tsc/testdata/baselines/reference/compiler/declFileMethods(target=es2015).js Removes private method comments.
tsc/testdata/baselines/reference/compiler/declFileAccessors(target=es2015).js Removes private accessor comments.
tsc/testdata/baselines/reference/compiler/declarationEmitPrivateAsyncMethod.js Removes private async method comments.
tsc/testdata/baselines/reference/compiler/commentsClassMembers(target=es2015).js Updates private member comment output.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread tsc/internal/transformers/declarations/transform.go

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Comment thread tsc/internal/transformers/declarations/transform.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Backlog Bug PRs that fix a backlog bug

2 participants