Merged
Conversation
…nhancement/e2e-tests
dkotter
approved these changes
Aug 12, 2024
Collaborator
|
@iamdharmesh E2E tests are failing now and I think it's due to the environment variables no longer existing (like |
Collaborator
Author
|
@dkotter, I can see the environment variables on the list. However, if you are talking about E2E tests failing in recent PRs from dependabot then it's due to repo secrets are not available for PR raised by bot or from the forked repo. So, this is expected (I am not sure on how we can make repo secrets available to the Dependabot PRs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
PR adds some new end-to-end tests for the plugin based on the critical flow wiki.
How to test the Change
Make sure tests running properly and passing in local or in GH action.
Changelog Entry
Credits
Props @iamdharmesh
Checklist: