feat(anthropic): support 1.0 sdk - #39938
Merged
Merged
Conversation
ccurme (ccurme)
requested review from
Eugene Yurtsev (eyurtsev) and
Mason Daugherty (mdrxy)
as code owners
August 26, 2026 15:20
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Mason Daugherty (mdrxy)
previously approved these changes
Aug 26, 2026
| return payload | ||
|
|
||
| extra_body = payload.get("extra_body") | ||
| if extra_body is not None and not isinstance(extra_body, dict): |
There was a problem hiding this comment.
extra_body accepts any Mapping, not only dict. With anthropic==1.0.0, this currently fails through ChatAnthropic.invoke:
llm.invoke("hello", extra_body=MappingProxyType({"foo": "bar"}))when temperature is set, because this early return leaves it as an unsupported top-level SDK argument:
TypeError: Messages.create() got an unexpected keyword argument 'temperature'
Could we accept any Mapping, copy it to a dict, and merge the relocated sampling parameters? A regression test using MappingProxyType would cover this path.
ccurme (ccurme)
temporarily deployed
to
Scheduled testing
August 26, 2026 22:07 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following https://github.com/anthropics/anthropic-sdk-python/blob/main/MIGRATION.md.
Here we support both major versions in langchain-anthropic.