You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Improving C# documentation for Internationalizing games #12477
Issue description:
The C# documentation on implementing translation behavior is incomplete in some places and incorrect in others:
Automatically setting a language is missing a C# example
the code example given for Converting keys to text does not produce the expected result because string interpolation is evaluated before Object.Tr(). I suggest changing the snippet to status.Text = string.format(Tr("GAME_STATUS_{0}"), statusIndex); as this will produce the desire behavior and brings it in line with later examples. This was a misinterpretation of the code on my part. This code example has been clarified with comments.
the Placeholders section is missing a C# example and the guidance provided in the explanation is vague. I suggest swapping "equivalent feature" for "string.Format()".
Reopening, as the issue is still not addressed on master currently. The issue can be closed automatically once the PR is merged by linking it with a "closes #xxxx" text in the pull request description.
Activity
Update C# documentaiont in Internationalizing_games
Heretic717 commentedon Oct 29, 2026
created a PR for my suggested changes:
#12478 (comment)
Calinou commentedon Oct 30, 2026
Reopening, as the issue is still not addressed on
mastercurrently. The issue can be closed automatically once the PR is merged by linking it with a "closes #xxxx" text in the pull request description.