Skip to content

Fix cases where floats are promoted to doubles and then converted back to floats. (-Wdouble-promotion) - #1693

Open
BenLubar wants to merge 3 commits into
godotengine:masterfrom
BenLubar:double-promotion
Open

Fix cases where floats are promoted to doubles and then converted back to floats. (-Wdouble-promotion)#1693
BenLubar wants to merge 3 commits into
godotengine:masterfrom
BenLubar:double-promotion

Conversation

@BenLubar

@BenLubar BenLubar commented Jan 26, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@BenLubar
BenLubar requested a review from a team as a code owner January 26, 2025 01:14
@dsnopek

dsnopek commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

Thanks!

However, a lot of this is code we periodically copy into godot-cpp from Godot, and if we make these changes, they'll simply be overwritten the next time we synchronize with Godot.

PR #1715 is the next synchronization

So, these changes would need to have the parts from Godot split off and made into a PR for Godot, and if there's any parts that don't come from Godot (there might not be any), those can remain in a PR for godot-cpp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@BenLubar @dsnopek