Skip to content

support for <expr> by <expr> loops - #837

Merged
vendethiel merged 2 commits into
gkz:masterfrom
rhendric:for-by
Feb 2, 2016
Merged

support for <expr> by <expr> loops #837
vendethiel merged 2 commits into
gkz:masterfrom
rhendric:for-by

Conversation

@rhendric

@rhendric rhendric commented Feb 1, 2016

Copy link
Copy Markdown
Collaborator

It was already in the grammar, but the lexer was written such that it could never happen.

As a special case, for by in foo still treats by as an identifier rather than a keyword.

@vendethiel

Copy link
Copy Markdown
Contributor

Can you please add a test with said special case? I'll merge it after that :)

@rhendric

rhendric commented Feb 2, 2016

Copy link
Copy Markdown
Collaborator Author

It already exists! test/loop.ls, line 168

@vendethiel

Copy link
Copy Markdown
Contributor

Ah ok, you merely added it for that.

vendethiel added a commit that referenced this pull request Feb 2, 2016
support for <expr> by <expr> loops
@vendethiel
vendethiel merged commit 49416ac into gkz:master Feb 2, 2016
@vendethiel

Copy link
Copy Markdown
Contributor

Thanks again!

This was referenced Jan 11, 2018
@rhendric
rhendric deleted the for-by branch May 4, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants