Skip to content

some items in sidebar highlight incorrectly. #86

Closed

Description

@reverland

check https://docsify.js.org/#/cdn?id=other-cdn
click other-cdn, it won't be highlighted.

it is because sidebar highlight is computed from scroll position, but several headers in the last will never appear on top of viewport

Activity

  1. reverland commented on Feb 20, 2017

    @reverland
    ContributorAuthor

    why not getAndActive(sidebar, true, true) when isMobile is false?

  2. QingWei-Li commented on Feb 20, 2017

    @QingWei-Li
    Member

    The sidebar is hidden by default on the mobile. No need to scroll when the highlight.

  3. reverland commented on Feb 20, 2017

    @reverland
    ContributorAuthor

    no, I mean even if its not in mobiles, getAndActive should be perform?

  4. QingWei-Li commented on Feb 20, 2017

    @QingWei-Li
    Member

    Actually I just check the viewport less than 600px as a mobile.

  5. reverland commented on Feb 20, 2017

    @reverland
    ContributorAuthor

    大佬orz,

    我英文不好,就是想问不在viewport大于600px时getAndActive有什么考虑么

  6. added a commit that references this issue on Feb 21, 2017
    6b7fd41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugconfirmed as a bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions