You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Release 4.8.0 break things, e.g. https://jhildenbiddle.github.io/docsify-tabs tab doesn't work any more. #663
Also, if I'd like to download and import docsify.min.js@4.7.1, where could I find it?
Reply myself in case this is useful to others: Use <script src="https://unpkg.com/docsify@4.7.1/lib/docsify.min.js"></script>
Instead of <script src="https://unpkg.com/docsify/lib/docsify.min.js"></script>
This DOM has changed and caused docsify-tab to not work, can you fix it?
Now all html code inline elements will be in the p tag.(This is a bug before marked and has now been fixed.) So button will also be in the p tag.
Activity
dryruner commentedon Oct 31, 2018
Also, if I'd like to download and import docsify.min.js@4.7.1, where could I find it?
dryruner commentedon Oct 31, 2018
Reply myself in case this is useful to others:
Use
<script src="https://unpkg.com/docsify@4.7.1/lib/docsify.min.js"></script>Instead of
<script src="https://unpkg.com/docsify/lib/docsify.min.js"></script>QingWei-Li commentedon Oct 31, 2018
👆Cool! You first found a workaround.
You can specify the version number, for exampleI will check it.
dryruner commentedon Oct 31, 2018
Thanks!
QingWei-Li commentedon Oct 31, 2018
fixed in
4.8.1QingWei-Li commentedon Nov 1, 2018
@jhildenbiddle
This DOM has changed and caused docsify-tab to not work, can you fix it?
Now all
html codeinline elements will be in the p tag.(This is a bug before marked and has now been fixed.) Sobuttonwill also be in the p tag.https://github.com/markedjs/marked/blob/f1ddca7febad16eb7861af0a7135989df0eb8e80/lib/marked.js#L59-L64
I was compatible with this issue in
4.8.1, but I found that it caused other bugs #677, so I rolled back it.jhildenbiddle commentedon Nov 1, 2018
Fixed in docsify-tabs 1.0.6.
Thanks for the heads up, @QingWei-Li!
QingWei-Li commentedon Nov 1, 2018
You are right. I reread the marked source code, it does not wrap the block-level elements.
jhildenbiddle commentedon Nov 1, 2018
Hehe...
That's why I deleted my comment about wrapping all HTML in a
<p>. Turns out<button>tags are wrapped, but not all HTML. 😄pin old version of docsify
fix(compiler): prevent render of html code in paragraph, fixed docsif…