Repository navigation
Visiting homepage doesn't set homepage link in sidebar to active #1131
Description
Bug Report
Steps to reproduce
- Include a link to the homepage (
README.mdor whatever's defined in thehomepagesetting) in the sidebar - Visit the docs root.
What is current behaviour
- The sidebar link to the homepage does not have the
activeclass to highlight it, and its submenu is not expanded. - If the homepage link is clicked,
#/READMEis appended to the URL, and then theactiveclass is included.- The URL fragment is always
README, even if the file is called something else.
- The URL fragment is always
What is the expected behaviour
- The sidebar link to the homepage should have the
activeclass, and the submenu should be expanded. - There should only be one canonical URL for the homepage (preferably one without a fragment in the URL)
- The fragment should at least match the filename defined in
homepage
- The fragment should at least match the filename defined in
Other relevant information
-
Bug does still occur when all/other plugins are disabled?
-
Your OS: macOS 10.15.4
-
Node.js version: 13.13.0
-
yarn version: 1.22.4
-
Browser version: Chrome 80.0.3987.149
-
Docsify version: 4.11.3
-
Docsify plugins: pagination, copy-code
Please create a reproducible sandbox
Mention the docsify version in which this bug was not present (if any)
N/A
Reacted by Gabin Aureche
Activity
anikethsaha commentedon Apr 22, 2020
try setting
_sidebar.mdto/is not same ashome.mdso I would suggest using/as it will automatically render your homepage and it will set the active linksPS: thanks for filling the template completely and creating the sandbox.
its very rare to see here.
groenroos commentedon Apr 22, 2020
That does seem to fix the problem, thanks! 🎉
I do think the weirdness around linking to the proper name of the homepage file is something that should be fixed though. Or at least if this is intended behaviour, maybe it could be documented more clearly?
anikethsaha commentedon Apr 22, 2020
this is an intended behavior as we do ajax request to the file based on the URL and we do supported remote file rendering and even remote homepage.
yes, I do think it should be documented.
Feel free to submit a PR for the docs change
Mention docsifyjs#1131 pitfall
zhouzi commentedon May 12, 2020
Wouldn't it be possible to check for
config.homepageif the file cannot be requested based on the URL? I mean, if the URL is/, obviously.I opened a PR to update the documentation btw 🙂
Merge pull request #1174 from Zhouzi/patch-1