Repository navigation
fix: correct multiline toolbar hint about the semi-colon - #267
Open
Sanjays2402 wants to merge 1 commit into
Open
Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
In multiline mode the bottom toolbar read "(Semi-colon [;] will end the line)", but a trailing semi-colon does not end the line - it terminates the statement and submits the query for execution (cli_is_multiline / _multiline_exception treat a trailing ';' as end-of-input). The hint now reads "(Semi-colon [;] will run the query)". Closes dbcli#266
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #266
Description
In multiline mode the bottom toolbar read
(Semi-colon [;] will end the line). A trailing semi-colon does not end the line —cli_is_multiline/_multiline_exceptiontreat it as end-of-input, so the statement is submitted and run. The hint now reads(Semi-colon [;] will run the query).Added
tests/test_clitoolbar.pycovering the multiline hint text and the single-line case; it fails on the old string and passes with the fix.Checklist
CHANGELOG.mdfile.This change was prepared with AI assistance; the regression test was run locally and fails without the fix.