Allow the user to control the process of loading grammars & themes #31

Activity

1. pomber commented on Jul 26, 2023

   

   pomber

   on Jul 26, 2023

   Last edited by pomber

   Contributor

   More actions

   We could add a couple of functions to the highlight config:

   type Config = { 
     loadRawGrammar: (lang: {...}) => Promise<IRawGrammar>
     loadRawTheme: (name: string) => Promise<RawTheme>
   };

   But I'm not sure it will solve your use case, can you give me a more concrete example of your first two points?

   ---

   For the Next.js case, would it make sense to add a good revalidate default in Lighter?

   Also, isn't Next.js default to cache the fetch forever? Or does it need { next: { revalidate: false } }?
2. tom-sherman commented on Jul 26, 2023

   

   tom-sherman

   on Jul 26, 2023

   Author

   More actions

   can you give me a more concrete example of your first two points?

   Test environments are a common one, also deno without requiring permissions. In general syntax highlighting is a pure function, it's strange to me to require a network call without the ability to swap this out.

   Additionally this would allow for loading arbitrary themes and grammars not found in the standard set.

   For the Next.js case, would it make sense to add a good revalidate default in Lighter?

   I'd advise strongly against that. revalidate is a cost-incurring option, a library shouldn't make a default choice that incurs extra costs IMO.

   Also, isn't Next.js default to cache the fetch forever?

   That's correct, but this optimisation is skipped when setting export const revalidate = N on the route segment - in this case the grammars and themes will be refetched every N seconds - that's what was happening in code-hike/bright#21
3. pomber commented on Jul 26, 2023

   

   pomber

   on Jul 26, 2023

   Last edited by pomber

   Contributor

   More actions

   If I add { next: { revalidate: false } } to the fetchs in lighter, that shouldn't incur in extra costs, right?
4. tom-sherman commented on Jul 26, 2023

   

   tom-sherman

   on Jul 26, 2023

   Author

   More actions

   Apologies I misread. As far as I'm aware that configuration is a complete no-op. It's equivalent to not passing revalidate to fetch at all.
5. pomber commented on Jul 27, 2023

   

   pomber

   on Jul 27, 2023

   Contributor

   More actions

   Apologies I misread. As far as I'm aware that configuration is a complete no-op. It's equivalent to not passing revalidate to fetch at all.

   Wouldn't the revalidate: false on fetch override the revalidate: N on the page? So when the page revalidates the fetch doesn't. That should fix code-hike/bright#21.

   I'm just asking, I expect it to work like that but I have no idea.
6. wesbos commented on Oct 13, 2023

   

   wesbos

   on Oct 13, 2023

   More actions

   I found out while trying to present in front of a 1800 person conference that this package loads all the grammers from remote URLs 😆

   Lucky I just had to turn the wifi on and it fixed itself, but I would love to be able to load all these grammars locally. Or at least a web worker to cache them?
7. pomber commented on Oct 13, 2023

   

   pomber

   on Oct 13, 2023

   Last edited by pomber

   Contributor

   More actions

   I found out while trying to present in front of a 1800 person conference that this package loads all the grammers from remote URLs 😆

   Ups, sorry about that.

   How are you using it? (any bundler? framework? directly from the browser?) Lighter tries to load the grammars from the file system (node modules) first, and only goes to the network if that fails.
8. tom-sherman commented on Oct 13, 2023

   

   tom-sherman

   on Oct 13, 2023

   Author

   More actions

   Wouldn't the revalidate: false on fetch override the revalidate: N on the page?

   AFAIA no. The page value takes precedence.