chore(quick-edit): run setup and custom-build script before deploy - #6624
Merged
Conversation
🦋 Changeset detectedLatest commit: 66c8f6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-wrangler-6624You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6624/npm-package-wrangler-6624Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-wrangler-6624 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-create-cloudflare-6624 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-cloudflare-kv-asset-handler-6624npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-miniflare-6624npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-cloudflare-pages-shared-6624npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-cloudflare-vitest-pool-workers-6624npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-cloudflare-workers-editor-shared-6624npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-cloudflare-workers-shared-6624Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
edmundhung
force-pushed
the
edmundhung/fix-quick-edit-deployment
branch
from
September 4, 2024 10:41
2a9732d to
4db5b47
Compare
edmundhung
force-pushed
the
edmundhung/fix-quick-edit-deployment
branch
3 times, most recently
from
September 12, 2024 20:40
548fe1d to
adeeda6
Compare
edmundhung
force-pushed
the
edmundhung/fix-quick-edit-deployment
branch
from
September 12, 2024 20:41
adeeda6 to
66c8f6b
Compare
edmundhung
marked this pull request as ready for review
September 12, 2024 20:41
penalosa
approved these changes
Sep 13, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Fixes DEVX-1404
Our quick editor depends on Vscode with a restriction on installation with yarn only. However, this conflict with our packageManager settings which points to pnpm. This updates both the setup and build script to make sure vscode is happy when we run
pnpm run deploy.The
Deploy Pages Previewsjob proves thatpnpm run deployworks now. So it should be safe to say that our deploy script that runspnpm run deploywill work too. 👍🏼Author has addressed the following