Skip to content

chore(quick-edit): run setup and custom-build script before deploy - #6624

Merged
edmundhung merged 1 commit into
mainfrom
edmundhung/fix-quick-edit-deployment
Sep 13, 2024
Merged

chore(quick-edit): run setup and custom-build script before deploy#6624
edmundhung merged 1 commit into
mainfrom
edmundhung/fix-quick-edit-deployment

Conversation

@edmundhung

@edmundhung edmundhung commented Sep 3, 2024

Copy link
Copy Markdown
Member

What this PR solves / how to test

Fixes DEVX-1404

Our quick editor depends on Vscode with a restriction on installation with yarn only. However, this conflict with our packageManager settings which points to pnpm. This updates both the setup and build script to make sure vscode is happy when we run pnpm run deploy.

The Deploy Pages Previews job proves that pnpm run deploy works now. So it should be safe to say that our deploy script that runs pnpm run deploy will work too. 👍🏼

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: no feature update
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: no feature update
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included: To bump the version so the deploy script will re-run
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: no feature update
@changeset-bot

changeset-bot Bot commented Sep 3, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 66c8f6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/quick-edit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edmundhung edmundhung added the preview:quick-edit Trigger a quick edit preview deploy label Sep 3, 2024
@github-actions

github-actions Bot commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-wrangler-6624

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6624/npm-package-wrangler-6624

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-wrangler-6624 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-create-cloudflare-6624 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-cloudflare-kv-asset-handler-6624
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-miniflare-6624
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-cloudflare-pages-shared-6624
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-cloudflare-vitest-pool-workers-6624
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-cloudflare-workers-editor-shared-6624
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10838431340/npm-package-cloudflare-workers-shared-6624

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.76.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.2
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung
edmundhung force-pushed the edmundhung/fix-quick-edit-deployment branch from 2a9732d to 4db5b47 Compare September 4, 2024 10:41
@edmundhung
edmundhung force-pushed the edmundhung/fix-quick-edit-deployment branch 3 times, most recently from 548fe1d to adeeda6 Compare September 12, 2024 20:40
@edmundhung
edmundhung force-pushed the edmundhung/fix-quick-edit-deployment branch from adeeda6 to 66c8f6b Compare September 12, 2024 20:41
@edmundhung
edmundhung marked this pull request as ready for review September 12, 2024 20:41
@edmundhung
edmundhung requested a review from a team as a code owner September 12, 2024 20:41
@edmundhung
edmundhung requested a review from penalosa September 12, 2024 21:26
@edmundhung
edmundhung merged commit 66f5b25 into main Sep 13, 2024
@edmundhung
edmundhung deleted the edmundhung/fix-quick-edit-deployment branch September 13, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:quick-edit Trigger a quick edit preview deploy

2 participants