Repository navigation
[C3] Bump create-analog from 2.9.2 to 2.9.3 in /packages/create-cloudflare/src/frameworks - #16618
Conversation
🦋 Changeset detectedLatest commit: 4db6c70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
There was a problem hiding this comment.
Superseded by the review of
b50bbb6c.
This review, of ef03a08b
✅ Approved — A single patch-version bump of the create-analog framework CLI with no issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The create-analog version pin goes from 2.9.2 to 2.9.3, a patch release with one upstream bug fix. No code quality concerns.
📝 Documentation: ✅ LGTM
No documentation changes are needed for this dependency bump.
Reviewed commit: ef03a08b
There was a problem hiding this comment.
Superseded by the review of
5e84d9e2.
This review, of b50bbb6c
✅ Approved — This bumps the create-analog framework CLI by one patch version and adds a matching changeset. No issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The create-analog pin in packages/create-cloudflare/src/frameworks/package.json moves from 2.9.2 to 2.9.3, a patch release with one upstream bug fix. The new changeset .changeset/c3-frameworks-update-16618.md is well-formed: it marks create-cloudflare for a patch release, and its version table matches the bump. No other code in packages/create-cloudflare/src hardcodes a create-analog version.
📝 Documentation: ✅ LGTM
This dependency bump needs no documentation changes. The changeset describes the version update accurately.
Reviewed commit: b50bbb6c
|
The shared Playwright Chromium install failure on Ubuntu 26.04 is addressed by #16622, which updates Playwright to 1.61. Once that fix merges, this PR can be updated and CI rerun. The C3 |
b50bbb6 to
5e84d9e
Compare
There was a problem hiding this comment.
Superseded by the review of
476f6d87.
This review, of 5e84d9e2
✅ Approved — This bumps the create-analog framework CLI by one patch version and adds a matching changeset. No issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The create-analog pin in packages/create-cloudflare/src/frameworks/package.json moves from 2.9.2 to 2.9.3, a patch release with one upstream bug fix. The new changeset .changeset/c3-frameworks-update-16618.md is well-formed: it marks create-cloudflare for a patch release, and its version table matches the bump. No other code in packages/create-cloudflare/src hardcodes a create-analog version.
📝 Documentation: ✅ LGTM
This dependency bump needs no documentation changes. The changeset describes the version update accurately.
Reviewed commit: 5e84d9e2 — same changes as b50bbb6c, so this is that commit's review (no new review was run; line numbers are as of b50bbb6c)
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/runtime-types
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
@dependabot recreate |
Bumps [create-analog](https://github.com/analogjs/analog) from 2.9.2 to 2.9.3. - [Release notes](https://github.com/analogjs/analog/releases) - [Changelog](https://github.com/analogjs/analog/blob/v2.9.3/CHANGELOG.md) - [Commits](analogjs/analog@v2.9.2...v2.9.3) --- updated-dependencies: - dependency-name: create-analog dependency-version: 2.9.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
5e84d9e to
476f6d8
Compare
There was a problem hiding this comment.
Superseded by the review of
4db6c702.
This review, of 476f6d87
✅ Approved — This bumps the create-analog framework CLI by one patch version, and I found no issues. The CI workflow is expected to add the changeset again after the recreate.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The create-analog pin changes from 2.9.2 to 2.9.3, a patch release with one upstream bug fix. No other file pins create-analog, and the lockfile has no entry for it. The changeset that was removed when the pull request was recreated comes from .github/workflows/c3-dependabot-versioning-prs.yml, which generates c3-frameworks-update-<PR> changesets for Dependabot pull requests.
📝 Documentation: ✅ LGTM
This dependency bump needs no documentation changes.
Reviewed commit: 476f6d87
The following dependency versions have been updated: | Dependency | From | To | | ------------- | ----- | ----- | | create-analog | 2.9.2 | 2.9.3 |
There was a problem hiding this comment.
✅ Approved — This patch-level bump of create-analog comes with a correct generated changeset, and I found no issues.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The create-analog pin moves from 2.9.2 to 2.9.3. The restored changeset .changeset/c3-frameworks-update-16618.md marks create-cloudflare as a patch and lists the version change correctly.
📝 Documentation: ✅ LGTM
This dependency bump needs no documentation changes, and the changeset text is accurate.
Reviewed commit: 4db6c702
Bumps create-analog from 2.9.2 to 2.9.3.
Release notes
Sourced from create-analog's releases.
Changelog
Sourced from create-analog's changelog.
Commits
064add3chore: release 2.9.3 [skip ci]c635be3fix(vite-plugin-angular): keep compilation state until all parallel environme...